1575197 - Replace removed break statement when notifications are activated to avoid updating unnecessarily

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P3)

Description

[Mark Banner (:standard8)]

As per bug 1571567 comment 21 and onwards, there was a break statement removed from PopupNotifications.handleEvent function, that seems to avoid updating a popup if it is already open.

I think we should revert that change as we don't want to update the UI more than necessary.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1575197 - Replace removed break statement when notifications are activated to avoid updating unnecessarily. r?MattN

Comment 2

[Jorg K (CEST = GMT+2)]

Just for the record: When TB followed bug 1571567, we left the break in place. It's here now:
https://searchfox.org/comm-central/rev/d55fb7f2405fd4e07cb267851340626a63a8c270/mail/base/modules/GlobalPopupNotifications.jsm#503

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9d8686d7b49
Replace removed break statement when notifications are activated to avoid updating unnecessarily. r=MattN

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a9d8686d7b49