Closed Bug 1575197 Opened 3 months ago Closed 3 months ago

Replace removed break statement when notifications are activated to avoid updating unnecessarily

Categories

(Toolkit :: Notifications and Alerts, defect, P3)

defect
Points:
1

Tracking

()

RESOLVED FIXED
mozilla70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox70 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Regression)

Details

Attachments

(1 file)

As per bug 1571567 comment 21 and onwards, there was a break statement removed from PopupNotifications.handleEvent function, that seems to avoid updating a popup if it is already open.

I think we should revert that change as we don't want to update the UI more than necessary.

Points: 2 → 1
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/a9d8686d7b49
Replace removed break statement when notifications are activated to avoid updating unnecessarily. r=MattN
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Iteration: --- → 70.4 - Aug 19 - Sep 1
You need to log in before you can comment on or make changes to this bug.