1575220 - [Windows] Breach notifications are not displayed while High Contrast Mode is applied

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Ciprian Georgiu, Desktop QA]

Attachment: screenshot with the issue.png

Affected versions

• latest Nightly 70.0a1

Affected platforms

• Windows 10 x64

Preconditions

• have High Contrast mode applied on Windows
• have at least one breached site saved in the profile-- instructions on how to do this can be found here

Steps to reproduce

1. Access about:logins
2. Inspect the breach warning icon and the "X" button from breach notification banner.

Expected result

• The breach warning and the "X" button are correctly displayed.

Actual result

• The breach warning and the "X" button are not displayed.

Regression range

• Not a regression, I was able to reproduce it on older builds e.g. 70.0a1 (20190807215212) as well; one of the first builds with this feature implemented.

Additional notes

• It seems that other banners that are having a "X" button are affected by this, so it could be a more general issue.

Comment 1

[Matthew N. [:MattN]]

ntim thought he heard that platform was going to fix images to show in HC mode so maybe we don't need to do anything specific to about:logins now?

Comment 3

[Eitan Isaacson [:eeejay]]

The backplate feature will not be complete in time for this. I think removing the background images is the way to go.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

OK. Since this is P3 I assume that doesn't have to be done in 70. (Though I would still take a patch in early beta.)

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1576047 removed the background-image and replaced it with an <img>. This bug should be fixed once bug 1576047 is fixed.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Now that bug 1576047 has landed, can you please test this again?

Comment 7

[Ciprian Georgiu, Desktop QA]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)

Now that bug 1576047 has landed, can you please test this again?

Unfortunately, it is still reproducible on latest Nightly 71, the breach warning and the "X" button doesn't show up.

Comment 8

[Asa Dotzler [:asa]]

Attachment: breach-indicator.png

Comment 9

[Asa Dotzler [:asa]]

The breach indicator in the logins list is now visible but barely and certainly not visible enough being a dark red on a black background. The close x button on the breach notification banner is still completely invisible.

Comment 10

[Asa Dotzler [:asa]]

[Tracking Requested - why for this release]:

The accessibility team considers this a P1 defect because it substantially breaks the breach notification feature for low vision users.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 70 release, hoping we can get a fix in for beta 11 or 12 next week.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1575220 - Show breach notification icons in high contrast mode. r?MattN

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1575220 - Show the close icon in the confirmation-dialog in high contrast mode. r?MattN

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0a61485099
Show breach notification icons in high contrast mode. r=MattN
https://hg.mozilla.org/integration/autoland/rev/faaf976800c2
Show the close icon in the confirmation-dialog in high contrast mode. r=MattN

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0f0a61485099
https://hg.mozilla.org/mozilla-central/rev/faaf976800c2

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/233ae8d44b8e
https://hg.mozilla.org/releases/mozilla-beta/rev/0830139ba23d

Comment 18

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) and on the latest Nightly 71.0a1 (Build ID: 20191008214557) build on Windows 10 x64.

• The breach warning icon and the “x” button are correctly displayed in High Contrast Mode.