1575249 - Add a lint to check for source file permissions

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

Detect if the source file has +x permissions and set the right permissions.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1575249 - Add a lint to check for source file permissions r?ahal

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1575249 - Ride along: remove +x permissions on source files r?ehsan

Depends on D42672

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a531fd366fdf
Ride along: remove +x permissions on source files r=Ehsan

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18587 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a531fd366fdf

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1575249 - Run the check for incorrect file permissions in the CI r?ahal

Depends on D42672

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3076039dfbf4
Add a lint to check for source file permissions r=ahal
https://hg.mozilla.org/integration/autoland/rev/cd3f609f0081
Run the check for incorrect file permissions in the CI r=ahal

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3076039dfbf4
https://hg.mozilla.org/mozilla-central/rev/cd3f609f0081

Comment 11

[:Gijs (he/him)]

Is this meant to do something on Windows, which doesn't really have a real sense of +x ? Right now it seems to warn for all the files in m-c...

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Nope, where do you see that?

Comment 13

[:Gijs (he/him)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #12)

Nope, where do you see that?

$ ./mach lint --outgoing
path/to/mozilla-central/browser/app/nsBrowserApp.cpp
  0   error  Execution permissions on a source file  (file-perm)

path/to/mozilla-central/browser/app/winlauncher/LauncherProcessWin.cpp
  0   error  Execution permissions on a source file  (file-perm)
  0   error  Execution permissions on a source file  (file-perm)

path/to/mozilla-central/toolkit/xre/CmdLineAndEnvUtils.h
  0   error  Execution permissions on a source file  (file-perm)

path/to/mozilla-central/toolkit/xre/nsAppRunner.cpp
  0   error  Execution permissions on a source file  (file-perm)

? 5 problems (5 errors, 0 warnings)

I don't know why LauncherProcessWin shows up twice, and I haven't touched any permissions as part of writing a patch (patch is up on https://phabricator.services.mozilla.com/D44395 in case it's relevant)...

Comment 14

[Sylvestre Ledru [:Sylvestre]]

ok, merci!
I guess we should just disable the check on Windows (which I did in the bug 1578673)