Closed Bug 1575249 Opened 2 months ago Closed 2 months ago

Add a lint to check for source file permissions

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(3 files)

Detect if the source file has +x permissions and set the right permissions.

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a531fd366fdf
Ride along: remove +x permissions on source files r=Ehsan
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18587 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Upstream PR merged by moz-wptsync-bot
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3076039dfbf4
Add a lint to check for source file permissions r=ahal
https://hg.mozilla.org/integration/autoland/rev/cd3f609f0081
Run the check for incorrect file permissions in the CI r=ahal
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED

Is this meant to do something on Windows, which doesn't really have a real sense of +x ? Right now it seems to warn for all the files in m-c...

Flags: needinfo?(sledru)

Nope, where do you see that?

Flags: needinfo?(sledru) → needinfo?(gijskruitbosch+bugs)

(In reply to Sylvestre Ledru [:Sylvestre] from comment #12)

Nope, where do you see that?

$ ./mach lint --outgoing
path/to/mozilla-central/browser/app/nsBrowserApp.cpp
  0   error  Execution permissions on a source file  (file-perm)

path/to/mozilla-central/browser/app/winlauncher/LauncherProcessWin.cpp
  0   error  Execution permissions on a source file  (file-perm)
  0   error  Execution permissions on a source file  (file-perm)

path/to/mozilla-central/toolkit/xre/CmdLineAndEnvUtils.h
  0   error  Execution permissions on a source file  (file-perm)

path/to/mozilla-central/toolkit/xre/nsAppRunner.cpp
  0   error  Execution permissions on a source file  (file-perm)

? 5 problems (5 errors, 0 warnings)

I don't know why LauncherProcessWin shows up twice, and I haven't touched any permissions as part of writing a patch (patch is up on https://phabricator.services.mozilla.com/D44395 in case it's relevant)...

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(sledru)
Regressions: 1578673

ok, merci!
I guess we should just disable the check on Windows (which I did in the bug 1578673)

Flags: needinfo?(sledru)
Regressions: 1579346
No longer regressions: 1579346
Regressions: 1582399
You need to log in before you can comment on or make changes to this bug.