Add a lint to check for source file permissions
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(3 files)
Detect if the source file has +x permissions and set the right permissions.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D42672
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a531fd366fdf Ride along: remove +x permissions on source files r=Ehsan
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18587 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 6•4 years ago
|
||
bugherder |
Upstream PR merged by moz-wptsync-bot
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
|
||
Depends on D42672
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3076039dfbf4 Add a lint to check for source file permissions r=ahal https://hg.mozilla.org/integration/autoland/rev/cd3f609f0081 Run the check for incorrect file permissions in the CI r=ahal
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3076039dfbf4
https://hg.mozilla.org/mozilla-central/rev/cd3f609f0081
Comment 11•4 years ago
|
||
Is this meant to do something on Windows, which doesn't really have a real sense of +x ? Right now it seems to warn for all the files in m-c...
Assignee | ||
Comment 12•4 years ago
|
||
Nope, where do you see that?
Comment 13•4 years ago
|
||
(In reply to Sylvestre Ledru [:Sylvestre] from comment #12)
Nope, where do you see that?
$ ./mach lint --outgoing
path/to/mozilla-central/browser/app/nsBrowserApp.cpp
0 error Execution permissions on a source file (file-perm)
path/to/mozilla-central/browser/app/winlauncher/LauncherProcessWin.cpp
0 error Execution permissions on a source file (file-perm)
0 error Execution permissions on a source file (file-perm)
path/to/mozilla-central/toolkit/xre/CmdLineAndEnvUtils.h
0 error Execution permissions on a source file (file-perm)
path/to/mozilla-central/toolkit/xre/nsAppRunner.cpp
0 error Execution permissions on a source file (file-perm)
? 5 problems (5 errors, 0 warnings)
I don't know why LauncherProcessWin
shows up twice, and I haven't touched any permissions as part of writing a patch (patch is up on https://phabricator.services.mozilla.com/D44395 in case it's relevant)...
Assignee | ||
Comment 14•4 years ago
|
||
ok, merci!
I guess we should just disable the check on Windows (which I did in the bug 1578673)
Updated•1 year ago
|
Description
•