1575272 - Fix test_bug1036214.html to work with Fission

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task, P2)

Description

[Andrew McCreight [:mccr8]]

test_bug1036214.html checks that various cases throw in the cross-origin case. These throw in different ways when done cross-process. As was done in bug 1572895 for test_bug505915.html, I think it makes sense to change the origin to one that will not be cross-process.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1575272 - Fix DOM bindings tests to work with Fission.

This tests that various DOM things fail when done
cross-origin. They'll fail in a different way if done cross-process,
so change the origin used so that it is same-process, but
cross-origin, even with Fission.

Comment 2

[Andrew McCreight [:mccr8]]

test_crossOriginWindowSymbolAccess.html is basically the same thing.

Comment 3

[Kris Maglione [:kmag]]

(In reply to Andrew McCreight [:mccr8] from comment #1)

Created attachment 9086719 [details]
Bug 1575272 - Fix DOM bindings tests to work with Fission.

This tests that various DOM things fail when done
cross-origin. They'll fail in a different way if done cross-process,
so change the origin used so that it is same-process, but
cross-origin, even with Fission.

This worries me a bit. They should fail the same way whether in-process or out of process. I think we really do need to test both cross-origin-cross-process documents and cross-origin-same-process objects.

Or, at least, some of them. We'll never have a cross-origin-cross-process document, for instance. But we definitely will have cross-origin-cross-process Window and Location objects, and we should probably be sure that they behave exactly the same way as their same-process counterparts do...

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Kris Maglione [:kmag] from comment #3)

This worries me a bit. They should fail the same way whether in-process or out of process. I think we really do need to test both cross-origin-cross-process documents and cross-origin-same-process objects.

That's a fair point, that we should test for something in the Fission case. I can add some additional tests for the cases that we'd expect to work with Fission, which would exclude "xoObjects.push(SpecialPowers.unwrap(SpecialPowers.wrap(window[0]).document));". I think the other big difference is that the exception that gets thrown is different for the Fission case.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01ed7f4e9a8f
Fix DOM bindings tests to work with Fission. r=peterv

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/01ed7f4e9a8f

Comment 7

[Neha Kochar [:neha]]

Andrew, did we file a bug for adding the tests as discussed in comment 4?