1575304 - Remove ellipses after Learn more

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P3)

Description

[Betsy Mikel [:betsymi]]

Attachment: STP Feature Promotion.png

This is a request to remove the ellipses from Learn more. This is our preferred style and the spec is attached for reference.

Reason for this request:
We use ellipses with button or menu items when the action requires additional user input, usually via a dialog, an alert, or moving the operation to another window or part of the UI. We do not use an ellipsis in a link to indicate that more information is available at the destination.

Comment 1

[Johann Hofmann [:johannh]]

This is defined here: https://searchfox.org/mozilla-central/rev/03853a6e87c4a9405fce1de49e5d03b9e7a7a274/toolkit/locales/en-US/chrome/global/notification.dtd#9

For all our popup notifications. It's probably fine to change it for all of them.

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1575304 - Remove ellipses after Learn more r?johannh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3eb8e3d19e4
Remove ellipses after Learn more r=johannh

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1c83d4897c4
Backed out changeset c3eb8e3d19e4 for causing browser chrome failures on browser_popupNotification_learnmore.js

Comment 5

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=271194010&revision=c3eb8e3d19e49294a93f110061321782b38a0c5f&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-8%2Cm%28bc8%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271194010&repo=autoland&lineNumber=4195

Backout link: https://hg.mozilla.org/integration/autoland/rev/b1c83d4897c42a726f6a79e5510539d0dd989c2d

[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_learnmore.js | secondary action accesskey matches -
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_learnmore.js | number of extra secondary actions matches -
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - Buffered messages finished
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/popupNotifications/browser_popupNotification_learnmore.js | correct label - Got Learn more, expected Learn more…
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - Stack trace:
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - chrome://mochikit/content/browser-test.js:test_is:1590
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - chrome://mochitests/content/browser/browser/base/content/test/popupNotifications/browser_popupNotification_learnmore.js:onShown:53
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - chrome://mochitests/content/browser/browser/base/content/test/popupNotifications/head.js:runNextTest/<:86
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - chrome://mochitests/content/browser/browser/base/content/test/popupNotifications/head.js:onPopupEvent/listener/<:309
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - chrome://mochikit/content/browser-test.js:run:1642
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_learnmore.js | correct href -
[task 2019-10-14T19:45:50.040Z] 19:45:50 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_learnmore.js | link not hidden -

Comment 6

[Maxx Crawford [:maxx]]

Updated patch to account for this test, and am running it on the try server.

• https://hg.mozilla.org/try/rev/2fc1e7fdf541610d2e3ff585df8d4f6dab64d412
• https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a4821cfb63318ad4b8f0bce3c80ae3a756367ef&selectedJob=271198479

Comment 7

[Maxx Crawford [:maxx]]

(In reply to Maxx Crawford from comment #6)

Updated patch to account for this test, and am running it on the try server.

• https://hg.mozilla.org/try/rev/2fc1e7fdf541610d2e3ff585df8d4f6dab64d412
• https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a4821cfb63318ad4b8f0bce3c80ae3a756367ef&selectedJob=271198479

Is this enough to try and land again?

Comment 8

[Johann Hofmann [:johannh]]

Seems fine to me!

Comment 9

[Maxx Crawford [:maxx]]

Awesome. Catching my commit up to the latest and then re-tagging!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e677c03aabe
Remove ellipses after Learn more r=johannh

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6e677c03aabe