Move JSScript side-tables from Realm to Zone
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: tcampbell, Assigned: cfallin)
References
Details
Attachments
(1 file)
Bug 1568245 is failed because we still need access to the Realm during finalization of JSScript. One solution is to move these side-tables from Realm to Zone. The Zone can always be determined for a JSScript (which is always tenured). The original motivation for put these tables on the Realm was that JSScript is nominally in a single realm.
Chris will take a look at this.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Attached a WIP patch for this. One problem is that the code-coverage information tracked by the debugger (script-counts table) will differ if it is tracked per-Zone rather than per-Realm. (In the WIP patch, I removed the count-clearing code completely because the debugger attach/detach that would clear the stats occurs only on the Realm, not on the Zone, and if multiple realms share a Zone then we don't want to step on someone else's coverage and clear the stats.) At least one test (jit-test/tests/debug/Script-getOffsetsCoverage-02.js) fails because of this. Also -- if stats crosses compartments, do we have a potential security / side-channel issue here?
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Copying from Phabricator comments: here is a try link in which all the oranges appear to be pre-existing flaky tests/issues. Since the tree is open again, this should be ready to land! Will mark checkin-needed.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66c1afff3fef
Move JSScript side-tables from Realm to Zone. r=tcampbell,jonco
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•