Closed Bug 1575352 Opened 3 months ago Closed 3 months ago

Remove dynamic linking of urlmon for MinGW after our toolkit is updated

Categories

(Core :: Widget, task)

Unspecified
Windows
task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: toshi, Assigned: toshi)

References

Details

Attachments

(1 file)

The fix for Bug 1573051 added a call to CreateUri, but it broke MinGW build because urlmon.def in the toolkit does not exist for x64. As a workaround, we dynamic link urlmon.lib for MinGW. Once we update the toolkit, we should static link urlmon.

Assignee: nobody → tkikuchi
Blocks: 1575670
No longer blocks: 1575670
Depends on: 1575670

4eca0f08c43b73dc1dd908fad58bdfd7f6973119 introduced dynamic linking of urlmon
for MinGW as a workaround. Now that MinGW was updated, we can remove that
workaround.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/137971f64c25
Remove dynamic linking of urlmon for MinGW. r=aklotz
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.