1575359 - Change string on the button on the Lockwise Card

Status: RESOLVED FIXED

(Firefox :: Protections UI, task, P1)

Description

[Betsy Mikel [:betsymi]]

Current string says Open in Nightly, Open in Firefox, etc. Update to: View Logins

Reason for this change: The action should be focusing on where the user is going and what they will do when they get there, rather than what is technically happening when they select the button.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1575359 - Update string on the Lockwise card button.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0d7d7218f37
Update string on the Lockwise card button. r=fluent-reviewers,flod

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b0d7d7218f37

Comment 4

[Andreea Pavel [:apavel]]

Backed out on request from Erica

Backout: https://hg.mozilla.org/integration/autoland/rev/9781c938afa60cd1187eae6ade5b9588a33f551e

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Andreea Pavel [:apavel] from comment #4)

Backed out on request from Erica

Erica, can you give more background on the request? The reason I'm asking is that this change was already exposed for localization. If the string is going to re-land as is, I'd prefer to avoid losing existing translations (there are 17 already).

Comment 6

[Johann Hofmann [:johannh]]

No idea why this was backed out (and I can't find any public conversations). Unless Andrea can point us towards something this will probably just have to go into 71, since Erica is on public holiday today.

Comment 7

[Johann Hofmann [:johannh]]

(Which is probably fine)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a62d5742e64
Update string on the Lockwise card button. r=fluent-reviewers,flod CLOSED TREE

Comment 9

[Johann Hofmann [:johannh]]

🤔

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Johann Hofmann [:johannh] from comment #9)

🤔

Fill in the blanks: Erica pinged me on Slack earlier saying the back-out was a misunderstanding, I asked sheriffs on IRC to re-land (not sure we'll also get Beta at this point).

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 9089200 [details]
Bug 1575359 - Update string on the Lockwise card button.

Beta/Release Uplift Approval Request

• User impact if declined: Obsolete string in about:protections
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only changing a button label. The original patch landed before merge, but was backed out by mistake.
• String changes made/needed: Yes

Comment 12

[Johann Hofmann [:johannh]]

I see! Thanks for taking care of that.

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9089200 [details]
Bug 1575359 - Update string on the Lockwise card button.

string update for 70.0b3

Comment 14

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b8f5f48ee60

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7a62d5742e64

Comment 16

[Andreea Pavel [:apavel]]

(In reply to Johann Hofmann [:johannh] from comment #6)

No idea why this was backed out (and I can't find any public conversations). Unless Andrea can point us towards something this will probably just have to go into 71, since Erica is on public holiday today.

Hi, Erica left me an offline message on Slack about backing this out and i did so the next day. After she mentioned that it seemed that the backout was not needed as there were no issues with the patch so she'd ask for a relanding.

Johann I also pinged you on IRC before making the backout but seems like you were away