1575465 - Messages panel: WebSocket messages in HAR exports

Status: ASSIGNED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Hengyeow (:tanhengyeow)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36

Expected results:

When exporting resources into HAR, we should have WS messages included, so that users can share them out or debug them later by importing them.

Comment 1

[Hengyeow (:tanhengyeow)]

Attachment: Bug 1575465 - Messages panel: WebSocket messages in HAR exports. r=Honza

Allow WebSocket messages to be copied/saved as HAR.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I think it's safe to unassign this bug and make it available to others.

I am marking this as good first bug since the patch is already available and seems to be closed to be done.

Honza

Comment 3

[Surya Balakrishnan [:surya_b]]

Attachment: Bug 1575465 - Messages panel: WebSocket messages in HAR exports. r=Honza

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@surya_b: there is a patch, perhaps we could try to finish that? Still valid bug and it would be great to fix that.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Adding myself as a mentor. Patches are welcome.
This bug is still somethinge we want to have fixed, but it isn't a priority for the team at the moment.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:Honza, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit auto_nag documentation.

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is still valid bug. WS data should be part of HAR.

Comment 10

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 11

[Delta Tekalec]

Hello, I currently have a patch for this in progress. My patch adds an "_messages" field to HAR entries. This field is only populated for an entry where the request initiates a WS connection and sends or receives WS messages. The _messages items have a very similar format to Chrome's _webSocketMessages. It currently works for WS and seemingly SSE although I'm still seeing errors for that case, and I'm not sure if we want to provide support for them in this field.

I noticed the last time this was worked there was discussion of making this fully compatible with Chrome's HAR format. If this is still the path we want to follow I think it is feasible.

Please make me assignee on this issue. Any available reviewers, please get in touch with me so we can discuss next steps. Thank you.

Comment 12

[Delta Tekalec]

(In reply to Delta Tekalec from comment #11)

Hello, I currently have a patch for this in progress. My patch adds an "_messages" field to HAR entries. This field is only populated for an entry where the request initiates a WS connection and sends or receives WS messages. The _messages items have a very similar format to Chrome's _webSocketMessages. It currently works for WS and seemingly SSE although I'm still seeing errors for that case, and I'm not sure if we want to provide support for them in this field.

I noticed the last time this was worked there was discussion of making this fully compatible with Chrome's HAR format. If this is still the path we want to follow I think it is feasible.

Please make me assignee on this issue. Any available reviewers, please get in touch with me so we can discuss next steps. Thank you.

On second thought, it makes more sense to separate WS and SSE messages into separate attributes. That way we can maintain compatibility with Chrome's HAR format and leave the door open for SSE support in the future. I'd like to hear to hear from those with more experience however.

Comment 13

[Delta Tekalec]

Attachment: Bug 1575465 - Messages panel: WebSocket messages in HAR exports. r=honza

Comment 14

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thank you for the patch Delta!
Bomsy, thank you for reviewing it!

Comment 15

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 16

[Delta Tekalec]

While working this ticket, I found this bug. Web Socket messages that reproduce this bug also cause the HAR builder to fail on their originating requests. It seems very likely to me that they share the same cause.

Comment 17

[Delta Tekalec]

Attachment: Bug 1575465 - Messages panel: WebSocket messages in HAR exports. r=honza

Recreation of my previous patch because I could not reapply it locally
since migration to git.