1575471 - Move `make check` from mozharness to moz-automation.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mike Hommey [:glandium]]

Currently, we have no visibility on the time spent after the build finished, despite the fact that a large chunk is actually happening via make check (although thankfully more and more of it is moving out to separate tasks).

Also, the mozharness machinery for make check dates from when we were running in buildbot and takes care of turning builds orange instead of red in case of failure, etc. which doesn't do anything useful anymore.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1575471 - Properly report the beginning of automation tiers.

The automation tiers all have a dependency:
automation/%: automation-start/%

The dependency runs the command for BUILDSTATUS, making the resource
monitor aware of what tiers start. Unfortunately, Make decides to run
all these automation-start/% targets way before starting the
automation/% targets, because of how the interdependencies are laid out.

Use a slightly better way, albeit still biased, making the
automation-start/% target for a tier depend on the dependencies, which
at least ensures that the resource monitor doesn't see a tier starting
before its dependencies are finished.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1575471 - Move `make check` from mozharness to moz-automation.mk.

Currently, we have no real visibility on the time spent after the build
finished, despite the fact that a large chunk is actually happening via
make check (although thankfully more and more of it is moving out to
separate tasks).

Also, the mozharness machinery for make check dates from when we were
running in buildbot and takes care of turning builds orange instead of
red in case of failure, etc. which doesn't do anything useful anymore.

Comment 3

[Mike Hommey [:glandium]]

Ionut: Heads up: this is going to cause regressions on Linux and Windows builds times. They are only regressions in numbers. We are actually already spending that time, it's just not currently counted.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0a70852225b
Properly report the beginning of automation tiers. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/025bf16416a7
Move `make check` from mozharness to moz-automation.mk. r=froydnj

Comment 5

[Mike Hommey [:glandium]]

Attachment: Fixup bug 1575471 to unbust aarch64 builds on a CLOSED TREE.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9438b588c9fd
Fixup bug 1575471 to unbust aarch64 builds on a CLOSED TREE.

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c0a70852225b
https://hg.mozilla.org/mozilla-central/rev/025bf16416a7
https://hg.mozilla.org/mozilla-central/rev/9438b588c9fd

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/74c68706469e
Port bug 1575471 - Remove check-test from actions in linux.yml and windows.yml. rs=bustage-fix

Comment 9

[Ionuț Goldan [:igoldan]]

(In reply to Mike Hommey [:glandium] from comment #3)

Ionut: Heads up: this is going to cause regressions on Linux and Windows builds times. They are only regressions in numbers. We are actually already spending that time, it's just not currently counted.

Thanks for the heads up!