1575541 - Section titles aren't styled correctly per UX spec

Status: RESOLVED INVALID

(Firefox :: Site Identity, defect, P5)

Description

[(no longer active)]

In the UX spec, the section titles like "Blocked", "Allowed", "None Detected", and "Permissions Set" look different than in Nightly. In Nightly they're displayed as normal font but in the UX spec it appears they're drawn either in bold font or with a different opacity/colour that gives them a visual distinction from the rest of the text on the protections/identity panels.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

In bug 1572443, we purposely reduced the font-weight of those header labels. The latest spec with the "None Detected" section has the font-weight so I'll forward this to UX.

Comment 2

[(no longer active)]

Attachment: Screenshot

Interesting!

I think this looks particularly bad in the site information panel. Right now (in my super humble opinion) the "Permissions Set" text when the site has no special permissions looks completely out of place as if it's positioned incorrectly in the middle of the dialog. It's not clear at all that it's the title of a section visually at least to my eyes.

I'm attaching a screenshot.

Comment 3

[(no longer active)]

(The "Permissions Set" title itself doesn't help, the first time I read it I was unsure how to read it... "Permissions Set" as in the set of permissions, or permissions which have been set. The text below doesn't make it clear either.)

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Betsy, could you chime in here please re. comment 2 and comment 3?

Comment 5

[Eric Pang [:epang] UX]

Can we update the subheading to the following?

Weight: 600
Size: 12px
Colour: #737373

It helps with separating the sections, thanks for filing the bug Eshan!

Comment 6

[Betsy Mikel [:betsymi]]

Johann, we had changed it to Permissions, right?

Comment 7

[Johann Hofmann [:johannh]]

(In reply to Betsy Mikel [:betsymi] from comment #6)

Johann, we had changed it to Permissions, right?

We had.

(In reply to Eric Pang [:epang] UX from comment #5)

Can we update the subheading to the following?

Weight: 600
Size: 12px
Colour: #737373

It helps with separating the sections, thanks for filing the bug Eshan!

Just to double-check, the "permissions" heading now looks different than the Blocked and Allowed headings (it has an icon and was restyled as part of that). That design came from Bryan. It fits the "Connection Secure" label now. Are you sure that we want to make this inconsistent again? I think we're actually in a good place right now.

Comment 8

[Eric Pang [:epang] UX]

ah, I see what you mean, that icon causes confusion since subheadings don't usually have icons. Let's leave as is. Thanks!

Comment 9

[Johann Hofmann [:johannh]]

Thanks!