157564 - PPEmbed - Advanced... Button on download form does not function

Status: VERIFIED INVALID

(Core Graveyard :: Embedding: Mac, defect)

Description

[moconnell]

Click a file link to download. When the XUL UI for downloading is displayed,
push the Advanced... button. Nothing happens. Expected result, get the Advanced
sheet.

Comment 1

[Greg K.]

[e-mail], please provide additional information.

1. What Build ID are you using?
2. What link are you clicking from what URL?

This definitely isn't Embedding. Let's try File Handling for now.

Comment 2

[Conrad Carlen (not reading bugmail)]

Bringing back to embedding. It works in PPEmbed run from viewer_debug. If it
doesn't work in the packaged Embed build, then something is missing from the
chrome in the packaged build.

Comment 3

[Mike Pinkerton (not reading bugmail)]

mine.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: fix

export the required mimetype defaults.

Comment 5

[Mike Pinkerton (not reading bugmail)]

ccing conrad for r=, sfraser for sr

Comment 6

[Conrad Carlen (not reading bugmail)]

Comment on attachment 92425 [details] [diff] [review]
fix

r=ccarlen

Comment 7

[Simon Fraser [no longer active]]

Comment on attachment 92425 [details] [diff] [review]
fix

sr=sfraser

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 92425 [details] [diff] [review]
fix

a=asa (on behalf of drivers) for checkin to the branch.

Comment 9

[Paul Wyskoczka]

Adding adt1.0.1+ on behalf on the adt.  Please get drivers approval before
checking into the branch. 

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Asa approved this for branch but didn't add mozilla1.0.1+.  When fixed in branch
please change mozilla1.0.1+ to fixed1.0.1

Comment 11

[Mike Pinkerton (not reading bugmail)]

landed on branch, will get trunk approval shortly.

Comment 12

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 1.1

Comment 13

[Mike Pinkerton (not reading bugmail)]

landed on trunk 8/15/02

Comment 14

[David Epstein]

Checked against trunk build Mozilla 1.3a Mozilla/5.0 (Macintosh; U; PPC Mac OS
X; en-US; rv:1.3a) Gecko/20021209. Verified patch checkin against the build. But
using PPEmbed, went to some sites including latest mozilla build and clicked on
file to download (e.g.
ftp://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk/mozilla-macosX-trunk.smi.bin)
A download dialog appears, but there is NO Advanced button (Only Save and
Cancel). In the Mozilla build, the Advanced button appears and when pressed
opens the Advanced form. Should also check this against a branch build.

Can someone point to a url where the Advanced button appears in the PPEmbed
download dialog? If this issue can't be resolved, I'm inclined to think this bug
should be reopened.

Comment 15

[Conrad Carlen (not reading bugmail)]

> Can someone point to a url where the Advanced button appears in the PPEmbed
download dialog?

This bug isn't relevant anymore. When it was originally filed and fixed, PPEmbed
was using the same XUL UI for downloads as Mozilla and, in that UI, there should
be an "Advanced" button. Since then, PPEmbed implemented its own download UI
which, by design, has no advanced button.

So, this bug can't be verified, only reopened and closed as invalid. 

Comment 16

[David Epstein]

Thanks Conrad. Reopening to resolve as invalid.

Comment 17

[David Epstein]

see Conrad's Comment #15.

Comment 18

[David Epstein]

verified