1575657 - Improve performance for React Asteroid

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect, P2)

Description

[Jason Laster [:jlast]]

web replay should be able to record react asteroids with a reasonable performance slow-down.

https://github.com/chriz001/Reacteroids
https://codesandbox.io/s/react-asteroids-v90q1

Comment 1

[Jason Laster [:jlast]]

looks like a gfx bug

[
"https://crash-stats.mozilla.org/report/index/9b4e60a4-b743-44d2-af05-b7bb20190901",
"https://crash-stats.mozilla.org/report/index/764cc4b7-6acc-4af5-a772-b9d710190901",
"https://crash-stats.mozilla.org/report/index/b5c67ffd-b91e-4536-a736-3326a0190901"
]

Comment 2

[Brian Hackett [Laid off!]]

The problem here is that the recording process is not triggering the creation of any checkpoints, which causes things to get bogged down pretty quickly. The reason why we aren't creating checkpoints is that we only create a checkpoint on one path through PresShell::Paint(), and there are other paths taken when e.g. there are no updates needed to the frame tree (which will be the case when the only thing that changed is some canvas contents, as with this game). Changing Paint() so that a checkpoint is always created causes the game to run much better.

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Bug 1575657 - Always create record/replay checkpoints when painting, r=mstange.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/611bf4a5e7a2
Always create record/replay checkpoints when painting, r=mstange.

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/611bf4a5e7a2