1575663 - Enum value "2d-array" isn't parsed correctly

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect, P1)

Description

[Dzmitry Malyshau [:kvark]]

Our binding generator produces the _2d-array variant from it, which is obviously wrong. It should be _2d_array

Exact IDL:

enum GPUTextureViewDimension {
    "1d",
    "2d",
    "2d-array",
    "cube",
    "cube-array",
    "3d"
};

Exact output:

enum class GPUTextureViewDimension : uint8_t {
  _1d,
  _2d,
  _2d-array,
  Cube,
  Cube_array,
  _3d,
  EndGuard_
};

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: Improve WebIDL bindgen of enum variants starting with a digit

Comment 2

[Dzmitry Malyshau [:kvark]]

Triager: please assign a reviewer for my PR

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abd262d462b0
Improve WebIDL bindgen of enum variants starting with a digit r=bzbarsky

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/abd262d462b0