1575682 - De-duplicate profiler pop-up code

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Greg Tatum [:gregtatum]]

We have two different copies of the profiler popup code UI from the Gecko profiler add-on. We should de-duplicate the UI.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1575682 - Add a mechanism for the popup to signal that its size has changed

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1575682 - Bridge the perf actor so that it can be reused with the popup

Depends on D43116

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1575682 - Change the behavior of the popup shortcuts to stop the profiler on capture

This change is a one-liner, but I wanted to call it out in its own commit
since it is a true behavior change.

Depends on D43117

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1575682 - De-duplicate the profiler popup code

This changeset is the bulk of the changes. It should contain most of
the minimum necessary changes to have everything working correctly.

Depends on D43118

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1575682 - Rename the recording buttons, and add a cancel button

Depends on D43119

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1575682 - Stop the profiler popup from "blipping" with unrendered content

Depends on D43120

Comment 7

[Greg Tatum [:gregtatum]]

Julien, I believe I've addressed all your comments on this.

Comment 8

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85a4e41ec8b5b947f4fd3e6b12265fe8460f1ca0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31a67b9d47ab
Bridge the perf actor so that it can be reused with the popup r=julienw
https://hg.mozilla.org/integration/autoland/rev/985902e9abdb
Change the behavior of the popup shortcuts to stop the profiler on capture r=julienw
https://hg.mozilla.org/integration/autoland/rev/e4a75438c032
De-duplicate the profiler popup code r=julienw
https://hg.mozilla.org/integration/autoland/rev/abee6fadcd4d
Rename the recording buttons, and add a cancel button r=julienw
https://hg.mozilla.org/integration/autoland/rev/c44c69605b87
Add a mechanism for the popup to signal that its size has changed r=julienw
https://hg.mozilla.org/integration/autoland/rev/7e60a2013e96
Stop the profiler popup from "blipping" with unrendered content r=julienw

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7a9d59c5bd1
Backed out 6 changesets for causing devtools failures on browser_all_files_referenced.js CLOSED TREE

Comment 11

[Arthur Iakab [arthur_iakab]]

Backed out 6 changesets (bug 1575682) for causing devtools failures on browser_all_files_referenced.js CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/c7a9d59c5bd19e264408f9ed3017fc43a8aa3745

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=264779097&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&revision=7e60a2013e967b1eebbcd4f85e1f0cac26b5724e&searchStr=dt

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=264779097&repo=autoland

Greg can you please take a look?

Comment 12

[Greg Tatum [:gregtatum]]

Oof, I totally didn't fix the error in my try run before landing.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405920f43feb
Bridge the perf actor so that it can be reused with the popup r=julienw
https://hg.mozilla.org/integration/autoland/rev/26400b2f0421
Change the behavior of the popup shortcuts to stop the profiler on capture r=julienw
https://hg.mozilla.org/integration/autoland/rev/597f7761880e
De-duplicate the profiler popup code r=julienw
https://hg.mozilla.org/integration/autoland/rev/a18707f036e0
Rename the recording buttons, and add a cancel button r=julienw
https://hg.mozilla.org/integration/autoland/rev/05e51bac8c99
Add a mechanism for the popup to signal that its size has changed r=julienw
https://hg.mozilla.org/integration/autoland/rev/d69418f996f7
Stop the profiler popup from "blipping" with unrendered content r=julienw

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/405920f43feb
https://hg.mozilla.org/mozilla-central/rev/26400b2f0421
https://hg.mozilla.org/mozilla-central/rev/597f7761880e
https://hg.mozilla.org/mozilla-central/rev/a18707f036e0
https://hg.mozilla.org/mozilla-central/rev/05e51bac8c99
https://hg.mozilla.org/mozilla-central/rev/d69418f996f7