Closed
Bug 1575757
Opened 6 years ago
Closed 5 years ago
Don't use `WITH RECURSIVE` to build the local tree
Categories
(Firefox :: Sync, task, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Since we now fetch the entire tree (including tags and non-syncable items), this query can be rewritten to walk moz_bookmarks twice (once for item info, and once for structure), just like fetch_remote_tree, instead of using WITH RECURSIVE. This might be faster than the CTE, since we can use an index; we'll have to profile.
|
Assignee | |
Comment 1•5 years ago
|
||
This commit replaces the localItems CTE with a single table scan
that fetches item and structure infos in one pass.
Depends on D43576
|
||
Updated•5 years ago
|
Attachment #9088360 -
Attachment description: Bug 1575757 - Don't use `WITH RECURSIVE` to build the local tree. r?markh! → Bug 1575757 - Don't use `WITH RECURSIVE` to build the local tree. r?tcsc!
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7438ce6ba80c
Don't use `WITH RECURSIVE` to build the local tree. r=tcsc
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•