1575794 - Increase in non-incremental GCs since 13th August

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Jon Coppeard (:jonco)]

Telemetry shows there has been an increase in the number of non-incremental GCs since 13th August:

https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=True%2520percentage&cumulative=0&end_date=null&include_spill=0&keys=&max_channel_version=nightly%252F70&measure=GC_NON_INCREMENTAL&min_channel_version=nightly%252F70&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=null&trim=1&use_submission_date=0

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1575794 - Fix INCREMENTAL_TOO_SLOW trigger to check the non-incremental threshold r?sfink

I missed changing this when I changed the threshold to be the incremental trigger rather than the non-incremental one. I'm not entirely sure we need this chech at all - I think it will only happen in the case where we've requested a non-incremental GC but the interrupt hasn't caused one to run yet.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee81fd49f90f
Fix INCREMENTAL_TOO_SLOW trigger to check the non-incremental threshold r=sfink

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ee81fd49f90f

Comment 4

[Florin Strugariu [:Bebe]]

== Change summary for alert #22957 (as of Wed, 04 Sep 2019 08:07:22 GMT) ==

Improvements:

2% raptor-ares6-firefox windows10-64-shippable-qr opt 59.90 -> 58.45

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22957