Closed Bug 1575918 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 18616 - Fix font-variation-settings interpolation test

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18616 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18616
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:

Fix font-variation-settings interpolation test

font-variation-settings is a map, not an array, so the order is
irrelevant when comparing the actual and expected values. Add the
ability to supply a custom comparison function to
interpolation-testcommon.js to support properties like this.

This also exposed one test which incorrectly asserted no interpolation
when there should be interpolation.

Bug: 900581
Change-Id: I6c336e010c9c3642b14c945b3d7ae828f94b3f99
Reviewed-on: https://chromium-review.googlesource.com/1764801
WPT-Export-Revision: de6a39f15b7b94d063622d1adfe2cc7dc4888b48

PR 18616 applied with additional changes from upstream: 92d4abd3c9f5ba2970467b540da200739af27a1f, b8fbe50ff0cecb7503bc14f5a15eb1d5eacc47cc, 81f8d11a1844e0881e7ad0ade1da3ac367b8d607, 6a439fd0334d0c7f57eb4cb58f29dbec1d026926, 5828ef1e4a44294f757d577d018efdb24031de5b
Ran 32 tests and 4696[linux64-qr-debug,linux64-qr-opt], 388[windows7-32-debug], 4892[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-opt] subtests OK : 32[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-opt], 2[windows7-32-debug], 31[linux64-qr-debug,linux64-qr-opt] PASS : 2564[windows7-32-opt], 4322[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt], 4412[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt], 4348[linux64-qr-debug,linux64-qr-opt] CRASH : 30[windows7-32-debug] FAIL : 480[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt], 2328[windows7-32-opt], 570[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt], 388[windows7-32-debug], 348[linux64-qr-debug,linux64-qr-opt] Tests that CRASH: /css/css-fonts/animations/font-size-adjust-interpolation.html: [windows7-32-debug] /css/css-fonts/animations/font-size-interpolation-001.html: [windows7-32-debug] /css/css-fonts/animations/font-size-interpolation-002.html: [windows7-32-debug] /css/css-fonts/animations/font-size-interpolation-003.html: [windows7-32-debug] /css/css-grid/animation/grid-template-columns-interpolation.html: [windows7-32-debug] /css/css-grid/animation/grid-template-rows-interpolation.html: [windows7-32-debug] /css/css-sizing/animation/width-interpolation.html: [windows7-32-debug] /css/css-transforms/animation/list-interpolation.html: [windows7-32-debug] /css/css-transforms/animation/matrix-interpolation.html: [windows7-32-debug] /css/css-transforms/animation/rotate-interpolation.html: [windows7-32-debug] /css/css-transforms/animation/scale-interpolation.html: [windows7-32-debug] /css/css-transforms/animation/translate-interpolation.html: [windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-001.html: [windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-002.html: [windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-003.html: [windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-004.html: [windows7-32-debug] /css/filter-effects/animation/filter-interpolation-001.html: [windows7-32-debug] /css/filter-effects/animation/filter-interpolation-002.html: [windows7-32-debug] /css/filter-effects/animation/filter-interpolation-003.html: [windows7-32-debug] /css/filter-effects/animation/filter-interpolation-004.html: [windows7-32-debug] /css/motion/animation/offset-anchor-interpolation.html: [windows7-32-debug] /css/motion/animation/offset-distance-interpolation.html: [windows7-32-debug] /css/motion/animation/offset-path-interpolation-001.html: [windows7-32-debug] /css/motion/animation/offset-path-interpolation-002.html: [windows7-32-debug] /css/motion/animation/offset-path-interpolation-003.html: [windows7-32-debug] /css/motion/animation/offset-path-interpolation-004.html: [windows7-32-debug] /css/motion/animation/offset-path-interpolation-005.html: [windows7-32-debug] /css/motion/animation/offset-rotate-interpolation.html: [windows7-32-debug] /feature-policy/experimental-features/layout-animations-disabled-tentative.html: [windows7-32-debug] /feature-policy/experimental-features/layout-animations-enabled-tentative.html: [windows7-32-debug] (truncated for maximum comment length)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d9178e91ea1 [wpt PR 18616] - Fix font-variation-settings interpolation test, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/953372c50f37 [wpt PR 18616] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/a19d7faf8cd9 [wpt PR 18616] - Fix font-variation-settings interpolation test, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/c56a952a950c [wpt PR 18616] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a19d7faf8cd9
https://hg.mozilla.org/mozilla-central/rev/c56a952a950c

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.