1576163 - Inline previews change height of a source line

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: 2019-08-23 15-07-15.mp4

Displaying inline preview boxes is changing height of a source line (in Debugger source view) and adding new previews when stepping causes the source to jump.

See the attached screencast.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I created separated bug 1576165 covering the React warning in the Browser Console.
Honza

Comment 2

[Jason Laster [:jlast]]

One option is increase the editor line height to 16px

Comment 3

[:Harald Kirschner :digitarald]

Removing this line fixes the line height changes: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/sourceeditor/codemirror/lib/codemirror.css#273

Correction: Removing it also causes the line-widget to overlay the code. Bad hack, but just removing also is bad.

Comment 4

[:Harald Kirschner :digitarald]

Switching from padding: 0.1px hack to display: flow-root in CodeMirror's CSS fixes this as well. Kudos to :dholbert for pointing this out!

Comment 5

[:Harald Kirschner :digitarald]

P2, as it was one of the risks we called out and a problem that we should not introduce.

Comment 6

[David Walsh :davidwalsh]

Attachment: Bug 1576163 - Prevent line shifting from inline preview r=jlast

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b5564dbb511
Prevent line shifting from inline preview r=jlast

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7b5564dbb511

Comment 9

[:Harald Kirschner :digitarald]

[Tracking Requested - why for this release]: Improves rendering for inline preview, which we so far would like to ship in 70.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this actually ready to ship in 70? I think it might be better to plan for 71.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Just found the planning docs for 70, I think I see what's up now.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Do you want to request uplift here?

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like this is now planned to ship in 71.