Closed Bug 1576168 Opened 4 months ago Closed 3 months ago

Update audio_thread_priority to 0.19.1

Categories

(Core :: Audio/Video: cubeb, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(2 files)

This allows catching SIGXCPU.

Priority: -- → P3

This changes the hard-limit of RLIMIT_RTTIME to be the maximum available
(200ms on my system), and keep the soft limit to the same number.

Having different numbers allow catching SIGXCPU before getting SIGKILL.

Blocks: 1575883
Assignee: nobody → padenot
Attachment #9088076 - Attachment description: Bug 1576168 - Update audio_thread_priority to 0.19.0 → Bug 1576168 - Update audio_thread_priority to 0.19.0. r?pehrsons
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e8fc76cd529
Update audio_thread_priority to 0.19.0. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/3ea6795200b1
mach vendor rust. r=pehrsons

Backed out 2 changesets (bug 1576168) for build bustages

Backout: https://hg.mozilla.org/integration/autoland/rev/f277c58a8bcb52c8d18dbdeb63de50dd8a8973d1

Failure push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3ea6795200b155f75de68931f12671a0b3b0c397

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263524487&repo=autoland&lineNumber=18565

[task 2019-08-26T16:44:28.638Z] 16:44:28 ERROR - error[E0432]: unresolved import mach_sys
[task 2019-08-26T16:44:28.638Z] 16:44:28 INFO - --> /builds/worker/workspace/build/src/third_party/rust/audio_thread_priority/src/rt_mach.rs:8:5
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - 8 | use mach_sys::*;
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - | ^^^^^^^^ help: a similar path exists: crate::mach_sys
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - = note: use statements changed in Rust 2018; read more at https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html
[task 2019-08-26T16:44:28.639Z] 16:44:28 ERROR - error[E0412]: cannot find type thread_t in this scope
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - --> /builds/worker/workspace/build/src/third_party/rust/audio_thread_priority/src/rt_mach.rs:16:34
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - 16 | fn thread_policy_set(thread: thread_t,
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - | ^^^^^^^^
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - help: a type alias with a similar name exists
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - 16 | fn thread_policy_set(thread: pthread_t,
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - | ^^^^^^^^^
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - help: possible candidates are found in other modules, you can import them into scope
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - 5 | use crate::mach_sys::thread_t;
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.639Z] 16:44:28 INFO - 5 | use mach::mach_types::thread_t;
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.640Z] 16:44:28 ERROR - error[E0412]: cannot find type thread_policy_flavor_t in this scope
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - --> /builds/worker/workspace/build/src/third_party/rust/audio_thread_priority/src/rt_mach.rs:17:34
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - 17 | flavor: thread_policy_flavor_t,
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - | ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - help: possible candidate is found in another module, you can import it into scope
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - 5 | use crate::mach_sys::thread_policy_flavor_t;
[task 2019-08-26T16:44:28.640Z] 16:44:28 INFO - |
[task 2019-08-26T16:44:28.640Z] 16:44:28 ERROR - error[E0412]: cannot find type thread_policy_t in this scope

Flags: needinfo?(padenot)
Attachment #9088076 - Attachment description: Bug 1576168 - Update audio_thread_priority to 0.19.0. r?pehrsons → Bug 1576168 - Update audio_thread_priority to 0.19.1. r?pehrsons
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e85d1ee673a
Update audio_thread_priority to 0.19.1. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/1f4a5ebd5c7b
mach vendor rust. r=pehrsons
Flags: needinfo?(padenot)
Summary: Update audio_thread_priority to 0.19.0 → Update audio_thread_priority to 0.19.1
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.