1576292 - URLClassifier gtests use directory service off the main thread

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[:Gijs (he/him)]

Stack:

[task 2019-08-23T19:56:05.794Z] 19:56:05     INFO -  #01: SetupLookupCache<mozilla::safebrowsing::LookupCacheV4>(nsTArray<nsTString<char> > const &) [toolkit/components/url-classifier/tests/gtest/Common.cpp:218]
[task 2019-08-23T19:56:05.794Z] 19:56:05     INFO -  #02: nsresult mozilla::detail::RunnableFunction<`lambda at z:/build/build/src/toolkit/components/url-classifier/tests/gtest/TestLookupCacheV4.cpp:15:22'>::Run() [xpcom/threads/nsThreadUtils.h:564]

Link: https://searchfox.org/mozilla-central/rev/a650fac7b069ded3d63eba530271ce80e6cafb1b/toolkit/components/url-classifier/tests/gtest/Common.cpp#218

There's a few other uses of NS_GetSpecialDirectory in that file that might want looking at as well.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1576292 - Avoid using directory service off-main-thread in URL Classifier gtest. r?gcp

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e698fd77a093
Avoid using directory service off-main-thread in URL Classifier gtest. r=gcp

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e698fd77a093