1576490 - Also fill the password confirmation field following the active field when filling a generated password

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Ahmed Halim]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

1- try to signup for any website that has a confirm password field in their signup page
2- right click on the password field > fill password > use a suggested password

Actual results:

only the password field is filled with the generated password

Expected results:

confirm password field should also be filled with the generated password for the feature to be usable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Matthew N. [:MattN]]

This is something we want to do but didn't make it for Fx70. Thanks for filing!

Comment 3

[Sam Foster [:sfoster] (he/him)]

I'm planning to look to see if the next form field is also a password, empty and not disabled, and fill the generated password value in there if so.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1576490 - Also fill generated password in the following password field when there is one. r?MattN

• Only fill as password confirmation field when the next input is/was a password type, not-disabled, and empty

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6ec5969c332
Also fill generated password in the following password field when there is one. r=MattN

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a6ec5969c332

Comment 7

[Sam Foster [:sfoster] (he/him)]

timea, would you be able to verify this patch with some of the account registrations and change password forms in the same list used for bug 1595244 and the new password model?

Comment 8

[Timea Cernea [:tbabos][inactive]]

Sure! (stealing NI? from my colleague Timea) I will check this out in the upcoming week.

Comment 9

[Sam Foster [:sfoster] (he/him)]

(In reply to Timea Cernea [:tbabos] from comment #8)

Sure! (stealing NI? from my colleague Timea) I will check this out in the upcoming week.

Thanks, sorry I didn't realize there were 2 Timeas :)

Comment 10

[Timea Cernea [:tbabos][inactive]]

No worries, its not the first time it happens :)

Verified this fix on the register/change password forms of 31 sites and all of them passed! You can also check them out here: https://docs.google.com/spreadsheets/d/1jm6e4A26CNasNfGjph6iIlMAsueh2gyu4fJQy2sqI-8/edit#gid=1304424193
Some of the sites did not have Retype/Confirm password fields or are too complicated to reach (Chinese sites and such), I took them out and did the rest.

Marking this as verified-fixed on latest Nightly 77.0a1 (2020-04-27) on Windows 10 x64.