1576608 - [RTL] Protections Report is not displayed correctly on RTL build

Status: RESOLVED INVALID

(Firefox :: Protections UI, defect, P3)

Description

[Andrei Purice]

Attachment: rtl.jpg

I have tested this issue on Windows 10 64-bit, Macos 10.11/10.14.06 and Linux 18.04.2 LTS on the Nightly version 70.0.1a(2019-08-25).

Steps :

1. Download and install the latest version of Nightly AR build.
2. Launch and access any site that requires a login(ex.: www.facebook.com) and login to an account and save the password.
3. Access "about:protections" in a new tab and browse through the elements.

Expected result :
All of the elements from the Privacy Protection section on a RTL build should be displayed correctly.

Actual result :
Some of the elements from the Privacy Protection section are not displayed correctly when using a RTL build.

Please check the attached file for more information.

Comment 1

[Andrei Purice]

Attachment: RTL2.jpg

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Unless there's bigger evidence this is a browser bug, this should probably live in another component.

Comment 3

[Johann Hofmann [:johannh]]

Sorry, can you help me out here and spell out what exactly is wrong about that screenshot?

Comment 4

[Andrei Purice]

Hello,

I thought it should mirror the image on the left which is a ss from a normal build. For example the number of blocked trackers in front of the text (because after it's just a sequence of numbers and it could be confusing), the hyperlinks in front of the text "Password stored securely" and "Not syncing to other devices".

Comment 5

[Johann Hofmann [:johannh]]

I would guess that this is just a Fluent hickup with using the uidirection pref with an LTR locale and that the problem isn't present on "real" RTL locales. Would be nice if someone who understand an RTL language could confirm that for me :)

Putting this in triage for now...

Comment 6

[Francesco Lodolo [:flod]]

Attachment: Hebrew build

I don't think icons should be mirrored, the rest seems correct to me.

@Itiel
Can you help us understanding is something looks off?

Comment 7

[Itiel]

@flod Thanks for tagging me in!

(In reply to Johann Hofmann [:johannh] from comment #5)

I would guess that this is just a Fluent hickup with using the uidirection pref with an LTR locale and that the problem isn't present on "real" RTL locales. Would be nice if someone who understand an RTL language could confirm that for me :)

Yep, that's accurate.
The only thing I see that could be improved for RTL here is to mirror the downvote and hammer icons, but that's a really minor issue and in any case not exclusive to about:protections (I think).
I'd close as RESOLVED INVALID.

(Andrei, thank you very much for reporting this even if it turned out there is no real issue here -- feel free to CC me next time if you find these kinds of RTL issues :) )

Comment 8

[(no longer active)]

Itiel, this isn't really an RTL issue per se, but I noticed that some of the day names in the Hebrew screenshot are wrapped into two lines. Is that expected or surprising?

Comment 9

[Itiel]

(In reply to :ehsan akhgari from comment #8)

Itiel, this isn't really an RTL issue per se, but I noticed that some of the day names in the Hebrew screenshot are wrapped into two lines. Is that expected or surprising?

I'd say surprising, because the strings are not that long that they should be wrapped (even though the strings there consist of 2 words ("Day A", "Day B" etc)).
Putting the readability annoyance aside, this is also problematic in a sense that the bars shift that way upwards, which may not be what the initial design meant to be.

Comment 10

[(no longer active)]

Thanks! If there is nothing else to be done in this bug perhaps we should morph it to improve the handling of week day names in the protection report? I can imagine there may be other languages which use a space in week day names besides Hebrew as well...

Comment 11

[Itiel]

(In reply to :ehsan akhgari from comment #10)

Thanks! If there is nothing else to be done in this bug perhaps we should morph it to improve the handling of week day names in the protection report? I can imagine there may be other languages which use a space in week day names besides Hebrew as well...

Filed bug 1577017.

Comment 12

[Johann Hofmann [:johannh]]

So can this be closed now?

Comment 13

[Itiel]

(In reply to Johann Hofmann [:johannh] from comment #12)

So can this be closed now?

I think so.

Comment 14

[Johann Hofmann [:johannh]]

Awesome, thank you for your help!

Comment 15

[Daniel Bodea [:danibodea]]

Attachment: the number is displayed at the end of text instead of beginning.png

Considering that this area was addressed in this bug, I want to make sure that it is correctly displayed. In this case, it appears that the number of trackers blocked is displayed at the right of the text. Is this correct or not?

Comment 16

[Itiel]

(In reply to Bodea Daniel [:danibodea] from comment #15)

Created attachment 9093881 [details]
the number is displayed at the end of text instead of beginning.png

Considering that this area was addressed in this bug, I want to make sure that it is correctly displayed. In this case, it appears that the number of trackers blocked is displayed at the right of the text. Is this correct or not?

For non-RTL languages this would be displayed incorrectly, as you see now. See comment 5.
If you'll try to reproduce on a real RTL localized version of Nightly (Hebrew, Arabic etc.) you'll see this works as expected.