Closed Bug 1576672 Opened 1 year ago Closed 1 year ago

Should not be able to select preview text

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: jlast, Assigned: alexand.dominguez)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

We should use user-select: none so that text highlighting is disabled.

I'm not sure I agree with this; for example, with name: "add", I may want to copy that "add" text. I may also want to highlight and copy a property name. In which case we're going to have to go rep type by rep type and stop certain rep types from being copyable.

I kinda like current mode as well. Selection out of the box worked really well, as it allows separate selection of the preview and code.

Are there good reasons now to make it non-selectable? We will surely have to reconsider this when we make the elements interactive.

One fear I had was that a massive copy and paste of the source code, while paused and with preview up, would select the preview text, but it doesn't. I think the current state is awesome.

I do not feel strongly about this, but we have made copying explicit and disabled text selection in other places e.g. (tabs, sources tree, call stack). I believe we used to do this in the scopes pane too. I personally find the text selection highlighting somewhat jarring and would rather expose "copy label" and "copy value" context menu items similar to what we do in other places. This will also give us the opportunity to consistently format the values appropriately as well.

Priority: -- → P3

Harald, care to make a call here?

Flags: needinfo?(hkirschner)

Given its a UI element, lets do not allow text selection to confirm with rest of Debugger. We should add it back intentionally via context menu.

Flags: needinfo?(hkirschner)

Does this qualify as a good first bug? If so, I'd like to take a stab at it.

Bug 1576672 - Disables the ability to highlight preview text in the Debugger. r=jlast

user-select: none rule was applied to the "inline-preview" class. Could instead have been applied to "CodeMirror-widget" class.

Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e1d3efe859d
Disables the ability to highlight preview text in the Debugger. r=jlast
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Assignee: nobody → alexand.dominguez
You need to log in before you can comment on or make changes to this bug.