1576675 - Cranelift: finish implementing x86 32-bits support

Status: RESOLVED INACTIVE

(Core :: JavaScript: WebAssembly, task, P5)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: enable-x86.patch

This is the Bugzilla mirror entry for https://github.com/CraneStation/cranelift/issues/765 . I've attached a patch that just enables ifdefery for 32-bits support, in case somebody wanted to have a look at this ;)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

This is very probably P5, considering the global tendency of x86 32-bits usage to go down over time, and with respect to other priorities.

Comment 2

[Ujjwal Sharma]

Starting to work on this! Thanks.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Cool, assigning to you then. Thanks!

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: enable-x86.patch

This sets up the right ISA target in Cranelift (duh!) and fixes return values sign-extensions.

Comment 5

[tt_1]

@bbouvier: if you haven't done that yet, please go to the cranelift github page and open a pullrequest. They're highly active at the moment, and will most likely be very supportive of your efforts.

Comment 6

[tt_1]

(In reply to tt_1 from comment #5)

@bbouvier: if you haven't done that yet, please go to the cranelift github page and open a pullrequest. They're highly active at the moment, and will most likely be very supportive of your efforts.

damit, just realized that your patch is for spidermonkey, I'm sorry :(

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to tt_1 from comment #6)

damit, just realized that your patch is for spidermonkey, I'm sorry :(

No worries! Also I'm :bnjbvr on Github, and working with Ujjwal Sharma (:ryzokuken on Github) to add more x86 support.

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

Ujjwal has moved on to other projects now. Thanks for your contributions!