Closed Bug 1576690 Opened 3 months ago Closed 3 months ago

Handle accessible mutations in shadow root slot changes

Categories

(Core :: Disability Access APIs, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

Bug 686400 introduced a delayed destruction for accessibles when they get reframed. This did not work well with shadow roots and their slots. This bug is a followup to get those cases covered.

This patch does several things:

  1. If there is a change to a host not or a slot, check the slottable
    elements to see if they are rendrered in the tree. Remove them if not.
  2. Check slot elements' fallback content if it is rendered and remove if
    not.
  3. Allow accssibles to be reinserted into a different parent or index.
Priority: -- → P1
Attachment #9088219 - Attachment description: Bug 1576690 - If (re)inserted content is in a shadow root and adjust tree. r?Jamie!,emilio! → Bug 1576690 - Prune de-slotted accessibles, or relocate them to new slot. r?Jamie!,emilio!
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/89963083c79d
Prune de-slotted accessibles, or relocate them to new slot. r=Jamie,emilio
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1578185
Regressions: 1578282
Regressions: 1581589
Regressions: 1585851
You need to log in before you can comment on or make changes to this bug.