1576761 - ./mach static-analysis check should not allow itself to be run on the whole tree

Status: NEW

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Description

[Tom Ritter [:tjr] (one week until extended leave)]

Running ./mach static-analysis check (to check the entire tree) does not complete on my machine. I left it running for 4+ days. Redirected to a file, it produced a file 2714763 lines long, 268M large. (Which is not very large for a file that took 4 days to make honestly.)

I thought maybe this was a pipe problem, so I ran ./mach static-analysis check --output log2.txt - but this still sent all the output to my terminal which I thought could be a bottleneck. So I ran ./mach static-analysis check --output log3.txt > /dev/null but this messed up the --output parameter and no file was written.

I'm not sure what I'm doing wrong here. I see repeated warnings, so I'm not sure if it's getting stuck repeating analyses or what... I do know that after 4 days it was no longer spawning any clang-tidy subprocesses and was spending 100% of it's time in python...

Comment 1

[Tom Ritter [:tjr] (one week until extended leave)]

After discussion, I learned that this command is never meant to be run on the entire tree. So I'm repurposing the bug to improve the command to prevent it from running on the entire tree and require you to give it a path/file.