Closed Bug 1576778 Opened 5 years ago Closed 4 years ago

Missing comment changes and typo in SitePermisions.jsm

Categories

(Firefox :: Site Permissions, defect, P3)

Product:
Firefox
Component:
Site Permissions
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 77
Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox70 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- fixed

People

(Reporter: iannbugzilla, Assigned: aarushivij, Mentored)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1576778 - Missing comment changes and typo in SitePermissions.jsm r=pbz
47 bytes, text/x-phabricator-request
Details | Review

When bug 1543812 landed it:

  1. added an extra parameter (permissionID) to the function getMultichoiceStateLabel (https://searchfox.org/mozilla-central/source/browser/modules/SitePermissions.jsm#883) but it wasn't documented in the comments above it probably needs to be something like:
    • @param {string} permissionID
    •    The permission to get the label for.
  2. added an extra supported option for gPermissionObject but nothing was added to the comments for that object about it, maybe something like:
      • getMultichoiceStateLabel
    • Allows for custom logic for getting its default value.
  3. created a typo Unkown rather than Unknown (https://searchfox.org/mozilla-central/source/browser/modules/SitePermissions.jsm#1028)

Unfortunately bugzilla incorrectly autoformats the suggestions

status-firefox70: affected → fix-optional
No longer depends on: 1543812
Keywords: regression
Priority: -- → P3
Regressed by: 1543812
Component: Site Identity → Site Permissions

Hello, Can I take up this issue?
Thanks :)
Aarushi

Flags: needinfo?(jhofmann)
Flags: needinfo?(iann_bugzilla)

Assigned you. Thanks!
Let me know if you have any questions.

Assignee: nobody → aarushivij
Mentor: pbz
Status: NEW → ASSIGNED
status-firefox70: fix-optional → wontfix
status-firefox74: --- → wontfix
status-firefox75: --- → wontfix
status-firefox76: --- → affected
status-firefox-esr68: --- → wontfix
Flags: needinfo?(jhofmann)
Flags: needinfo?(iann_bugzilla)
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/264817cbee37
Missing comment changes and typo in SitePermissions.jsm r=pbz

https://hg.mozilla.org/mozilla-central/rev/264817cbee37

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: