1576817 - find in page sometimes matches input placeholder text

Status: RESOLVED FIXED

(Core :: Find Backend, defect)

Description

[Cameron McCormack (:heycam)]

STR:

1. Open searchfox.
2. Press Ctrl+F / Cmd+F.
3. Type "m", notice that the "m" in the "Search mozilla-central" placeholder text selected.
4. Type "o", notice that the "mo" in the placeholder text does not get selected.

Not sure whether it should match or not, but it's weird that only a single character matches.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1576817 - Fix a regression from bug 1490974 where we'll fail to find visibility: visible descendants of visibility: hidden nodes.

The split between IsDisplayedNode and IsVisibleNode is pretty intentional, since
visibility: visible descendants of visiblity: hidden ancestors are in fact
visible.

We skip fully-invisible ranges in here instead:

https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/components/find/nsFind.cpp#776

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1576817 - Simplify some code added in bug 1490974.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1576817 - Only allow finding editable anonymous nodes in form controls.

We want to find the text inside the input that the user types, but not stuff
like the placeholder. So check that the anonymous subtree is editable, or skip
it otherwise.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34b4dcc475d3
Simplify some code added in bug 1490974. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/3192da5a883f
Only allow finding editable anonymous nodes in form controls. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/bcbd2fb36cb1
Fix a regression from bug 1490974 where we'll fail to find visibility: visible descendants of visibility: hidden nodes. r=bradwerth

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/34b4dcc475d3
https://hg.mozilla.org/mozilla-central/rev/3192da5a883f
https://hg.mozilla.org/mozilla-central/rev/bcbd2fb36cb1