Closed Bug 1576859 Opened 3 months ago Closed 2 months ago

about:license width broken

Categories

(Firefox :: General, defect, P2, minor)

70 Branch
All
Unspecified
defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- verified
firefox71 --- verified

People

(Reporter: robin, Assigned: mhoye)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Visited about:license

Actual results:

Massive horizontal scrollbar.

Expected results:

Fit to the width of the screen.

The cause seems to be a line in the BSD 3-Clause License that isn’t wrapping. This is in latest Nightly on macOS 10.14.

Severity: normal → minor
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
Regressed by: 1570697
Hardware: Unspecified → All

Thanks for filing this; you're right, that's incorrect, and it's my problem.

Assignee: nobody → mhoye
Component: Untriaged → General
Keywords: regression
Priority: -- → P2

Mike can you take this on, or, if not, help find someone who can work on it to get it into 70 beta? Thanks!

Flags: needinfo?(mhoye)

Emailing follow up.

Ok, I don't think I can self-review but the change is up.

Flags: needinfo?(mhoye)

Dolske can you help find a reviewer for Mike's patch?

Flags: needinfo?(dolske)
Flags: needinfo?(dolske)
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/235aa16859c3
resolve long lines in BSD 3-clause license by cutting <pre>-wrapped text r=florian

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Can you request uplift please?

Flags: needinfo?(mhoye)

Comment on attachment 9095008 [details]
Bug 1576859 - resolve long lines in BSD 3-clause license by cutting <pre>-wrapped text

Beta/Release Uplift Approval Request

  • User impact if declined: Bad UX in about:license
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's just about:license.
  • String changes made/needed:
Attachment #9095008 - Flags: approval-mozilla-beta?

Comment on attachment 9095008 [details]
Bug 1576859 - resolve long lines in BSD 3-clause license by cutting <pre>-wrapped text

line wrapping regression fix in about:license#bsd3clause, approved for 70.0b14

Flags: needinfo?(mhoye)
Attachment #9095008 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced the initial issue using an old Beta build: 20191007220302 and an old Nightly build: 20190827094743
Verified - fixed on latest Beta 70.0b14 (64-bit) (Build id: 20191010142853) and latest Nightly 71.0a1 (2019-10-10) (Build id: 20191010214019) on Mac OS 10.14 and Windows 10.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.