1576859 - about:license width broken

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Robin Whittleton]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Visited about:license

Actual results:

Massive horizontal scrollbar.

Expected results:

Fit to the width of the screen.

The cause seems to be a line in the BSD 3-Clause License that isn’t wrapping. This is in latest Nightly on macOS 10.14.

Comment 1

[Mike Hoye [:mhoye]]

Thanks for filing this; you're right, that's incorrect, and it's my problem.

Comment 2

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Mike can you take this on, or, if not, help find someone who can work on it to get it into 70 beta? Thanks!

Comment 3

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Emailing follow up.

Comment 4

[Mike Hoye [:mhoye]]

Attachment: Bug 1576859 - resolve long lines in BSD 3-clause license by cutting <pre>-wrapped text

Comment 5

[Mike Hoye [:mhoye]]

Ok, I don't think I can self-review but the change is up.

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Dolske can you help find a reviewer for Mike's patch?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/235aa16859c3
resolve long lines in BSD 3-clause license by cutting <pre>-wrapped text r=florian

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/235aa16859c3

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Can you request uplift please?

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 9095008 [details]
Bug 1576859 - resolve long lines in BSD 3-clause license by cutting <pre>-wrapped text

Beta/Release Uplift Approval Request

• User impact if declined: Bad UX in about:license
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's just about:license.
• String changes made/needed:

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9095008 [details]
Bug 1576859 - resolve long lines in BSD 3-clause license by cutting <pre>-wrapped text

line wrapping regression fix in about:license#bsd3clause, approved for 70.0b14

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe97faa4dc3e

Comment 13

[Alin Ilea, Desktop QA]

Reproduced the initial issue using an old Beta build: 20191007220302 and an old Nightly build: 20190827094743
Verified - fixed on latest Beta 70.0b14 (64-bit) (Build id: 20191010142853) and latest Nightly 71.0a1 (2019-10-10) (Build id: 20191010214019) on Mac OS 10.14 and Windows 10.