Closed
Bug 1576881
Opened 6 years ago
Closed 6 years ago
Use custom type objects for complex props
Categories
(DevTools :: Application Panel, enhancement, P1)
DevTools
Application Panel
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: ladybenko, Assigned: ladybenko)
References
(Blocks 1 open bug)
Details
(Whiteboard: [manifest-reserve])
Attachments
(2 files)
We have places in our code where we specify props with PropType.array
or PropType.object
. We should actually specify how these arrays or objects look like. Since some of the types are being re-used, the proper way would be to use custom types, like we in remote debugging: https://searchfox.org/mozilla-central/search?q=&case=false®exp=false&path=aboutdebugging%2F**%2Ftypes
![]() |
Assignee | |
Updated•6 years ago
|
Priority: -- → P3
![]() |
Assignee | |
Updated•6 years ago
|
Whiteboard: [triage]
![]() |
Assignee | |
Updated•6 years ago
|
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: P3 → P1
Updated•6 years ago
|
Whiteboard: [manifest-reserve]
![]() |
Assignee | |
Comment 1•6 years ago
|
||
![]() |
Assignee | |
Comment 2•6 years ago
|
||
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07c901d7f04e
Part 1: Use custom prop types for manifest components r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/420cf92dd35c
Part 2: Use custom prop types for workers and routing components r=jdescottes
![]() |
||
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/07c901d7f04e
https://hg.mozilla.org/mozilla-central/rev/420cf92dd35c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•