1576893 - webrtc/RTCPeerConnection-iceConnectionState.https.html has an invalid test

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

The "Responder ICE connection state behaves as expected" test-case has been marked as intermittent on linux and android. Need to figure out why this is.

Comment 1

[Byron Campen [:bwc]]

This looks like a bug in the test-case to me; it waits for ICE to complete on pc1, but not pc2, then asserts that pc2 has already reached ICE complete. The test case needs to wait for pc2 to reach ICE complete also.

Comment 2

[Byron Campen [:bwc]]

Marking a defect because the test is buggy.

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1576893: Wait for ICE to complete on pc2 before checking ICE state transitions. r?jib

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e042747a50d5beba3d46c1cee22b5d6934061c7

Comment 6

[Byron Campen [:bwc]]

Looks like this change was backed out, but it will likely re-land. We'll have to wait for that to happen before landing this.

Comment 7

[Intermittent Failures Robot]

16 failures in 1013 pushes (0.016 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 10
• mozilla-central: 3
• mozilla-inbound: 3

Platform breakdown:

• macosx1014-64: 5
• macosx1014-64-shippable: 4
• linux64-qr: 2
• linux32-shippable: 3
• linux64-shippable-qr: 1
• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1576893&startday=2019-08-29&endday=2019-08-29&tree=all

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7134186c04b2
Wait for ICE to complete on pc2 before checking ICE state transitions. r=jib

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18782 for changes under testing/web-platform/tests

Comment 11

[Cosmin Sabou [:CosminS]]

The patch conflicted with the changes here: https://hg.mozilla.org/integration/autoland/rev/dcf08f0a3f22f0ead12e75e7bdda56c573dac71c so I rebased and landed it. Byron, if it's not ok with you I'll back it out.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 13

[Intermittent Failures Robot]

44 failures in 5047 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #38 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-inbound: 13
• autoland: 20
• mozilla-central: 8
• mozilla-beta: 1
• try: 2

Platform breakdown:

• macosx1014-64: 15
• macosx1014-64-shippable: 8
• linux32-shippable: 11
• linux64-qr: 2
• linux64-shippable: 3
• linux64-shippable-qr: 4
• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1576893&startday=2019-08-26&endday=2019-09-01&tree=all

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7134186c04b2

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[Intermittent Failures Robot]

2 failures in 4408 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 2

Platform breakdown:

• linux64-devedition: 1
• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1576893&startday=2019-09-02&endday=2019-09-08&tree=all

Comment 18

[Intermittent Failures Robot]

4 failures in 4314 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 4

Platform breakdown:

• linux32-shippable: 2
• linux64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1576893&startday=2019-10-28&endday=2019-11-03&tree=all

Comment 19

[Intermittent Failures Robot]

2 failures in 4207 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform breakdown:

• linux32-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1576893&startday=2019-11-11&endday=2019-11-17&tree=all