Closed Bug 1576908 Opened 3 months ago Closed 2 months ago

[Fission][MSU capstone] Purge session history notifications should use fission for messaging

Categories

(Toolkit :: Data Sanitization, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: Gijs, Assigned: staatsty, Mentored)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Note that we're planning to point an MSU student at this bug for the fall semester. :-)

Summary: [Fission] Purge session history notifications should use fission for messaging → [Fission][MSU capstone] Purge session history notifications should use fission for messaging
Priority: -- → P2
Assignee: nobody → staatsty
Attachment #9094233 - Attachment description: Bug 1576908 - Ported PurgeMessageHistory to use JSwindow actors for internal messaging → Bug 1576908 - Ported PurgeMessageHistory to use JSwindow actors for internal messaging(removed console.logs and some white space)

Hey Tyler, two things:

  1. Both of these patches still have the "Changes Planned" tag on it, which is why we haven't started reviewing them yet
  2. These patches probably should get rolled together. This is not something I showed any of you how to do during the hack weekend, but if you're familiar with Git's interactive rebase, then the steps are similar.

How to roll these two patches together:

  1. Make sure the most recent commit is checked out. Use hg log --graph to note the SHA of the second-most recent commit. Presumably these are the two we are rolling together.
  2. Use hg histedit -r <SHA of second-most recent commit>, and hopefully an editor interface will open up. Hopefully it's one you're familiar with.
  3. Find the line that has the most recent commit message, and change the first word in that line from "pick" to "roll"
  4. Save and exit the editor.

This will fold up the two commits, and then you can use moz-phab to submit the one change. At that point, inside of the Phabricator revision, don't forget to choose "Request Review" from the dropdown list at the bottom of the page, and then click "Submit" in order for it to show up in our queues.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ff09f16f5b3d
uses fission model for sending purge history messages r=mconley,Gijs
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1589939
No longer regressions: 1589939

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.