1576908 - [Fission][MSU capstone] Purge session history notifications should use fission for messaging

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, task, P2)

Description

[:Gijs (he/him)]

This is the code that updates a browser/docshell's history state:

https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/content/widgets/browser-custom-element.js#1601-1616

Actor spec:

https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/toolkit/modules/ActorManagerParent.jsm#349-354

This should use the fission-compatible actor infrastructure to send the message instead.

Comment 1

[:Gijs (he/him)]

Note that we're planning to point an MSU student at this bug for the fall semester. :-)

Comment 2

[:Gijs (he/him)]

Note: we'll need to take care of RDM, see https://firefox-source-docs.mozilla.org/dom/dom/Fission.html#do-not-break-responsive-design-mode-rdm and https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/devtools/client/responsive/browser/tunnel.js#447 .

Comment 3

[Tyler]

Attachment: Bug 1576908 - uses fission model for sending purge history messages

Comment 4

[Tyler]

Attachment: Bug 1576908 - Ported PurgeMessageHistory to use JSwindow actors for internal messaging(removed console.logs and some white space)

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hey Tyler, two things:

1. Both of these patches still have the "Changes Planned" tag on it, which is why we haven't started reviewing them yet
2. These patches probably should get rolled together. This is not something I showed any of you how to do during the hack weekend, but if you're familiar with Git's interactive rebase, then the steps are similar.

How to roll these two patches together:

1. Make sure the most recent commit is checked out. Use hg log --graph to note the SHA of the second-most recent commit. Presumably these are the two we are rolling together.
2. Use hg histedit -r <SHA of second-most recent commit>, and hopefully an editor interface will open up. Hopefully it's one you're familiar with.
3. Find the line that has the most recent commit message, and change the first word in that line from "pick" to "roll"
4. Save and exit the editor.

This will fold up the two commits, and then you can use moz-phab to submit the one change. At that point, inside of the Phabricator revision, don't forget to choose "Request Review" from the dropdown list at the bottom of the page, and then click "Submit" in order for it to show up in our queues.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff09f16f5b3d
uses fission model for sending purge history messages r=mconley,Gijs

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ff09f16f5b3d

Comment 8

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732