1576914 - Error running mozregression for android device

Status: RESOLVED FIXED

(Testing :: Mozbase, defect, P2)

Description

[Jamie Nicol [:jnicol]]

On a fresh install of mozregression (and dependencies) today, running mozregression --app gve fails. I get the following output:

0:17.84 INFO: detect /system/bin/ls args: adb wait-for-device shell /system/bin/ls, exitcode: 1, stdout: ls: ./init.zygote64_32.rc: Permission denied
ls: ./init.environ.rc: Permission denied
ls: ./init.rc: Permission denied
ls: ./init.usb.configfs.rc: Permission denied
ls: ./cache: Permission denied
ls: ./init: Permission denied
ls: ./ueventd.rc: Permission denied
ls: ./init.zygote32.rc: Permission denied
ls: ./init.usb.rc: Permission denied
ls: ./postinstall: Permission denied
ls: ./persist: Permission denied
acct
bin
bugreports
charger
config
d
data
default.prop
dev
dsp
etc
firmware
lost+found
mnt
odm
oem
proc
product
res
sbin
sdcard
storage
sys
system
vendor
 0:17.95 INFO: detect /system/xbin/ls : args: adb wait-for-device shell /system/xbin/ls, exitcode: 127, stdout: /system/bin/sh: /system/xbin/ls: not found

which repeats a few times then exits.

I manually downgraded the version of mozdevice from 3.0.5 to 3.0.3 and it works again. So something in 3.0.4 or 3.0.5 broke this.

This is on a non-rooted stock Android 9 Pixel 2, and happens when running mozregression on either my macbook or fedora desktop.

Is there any more information which would be useful?

Comment 1

[William Lachance (:wlach)]

Hey :bc, any idea what might be happening here?

Comment 2

[Bob Clary [:bc] (inactive)]

3.0.5 changed the way ls was detected from device.is_file to actually running it without arguments. It appears this caused it to list the root directory which in your case has some files which can't be listed. I could do for ls what I did for some of the other commands and see if some form of --help would be sufficient for detection. I'll fix this as soon as I can.

Comment 3

[Bob Clary [:bc] (inactive)]

mozdevice has had several updates since this. I confirmed it is working using mozregression 3.0.3 with mozdevice 3.0.7.