1577031 - Allow opening about:protections from UITour websites

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Erica Wright [:ewright]]

We'd like to be able to share a link to the protection report.

1. If a user is not on Firefox we'd like it to lead to a page giving a sample of the report and prompting a download.
2. If the user is on an older version we'd like to lead them to a sample of the report and prompt them to upgrade.
3. If a user is on 70+ Firefox it will lead to the report.

Step 1 and 2 will require building a website, this will be done elsewhere.

This bug is for implementing step 3, making about:protections link-able from external places.

Comment 1

[chsiang]

Erica, could you share the link when you have it so the marketing team and set up the moz.org redirect?

Thanks.
Cindy

Comment 2

[Erica Wright [:ewright]]

(In reply to chsiang from comment #1)

Erica, could you share the link when you have it so the marketing team and set up the moz.org redirect?

Thanks.
Cindy

I believe the link will simply be "about:protections", but I'll confirm that once it is functional.
(Unless you mean the link for the webpage, in that case marketing/moz.org team can pick whatever link they like, ex. mozilla.org/protection_report.)

Comment 3

[Johann Hofmann [:johannh]]

We should not make about:protections directly linkable, instead I'd prefer to provide a special JS API via UITour that allows the site to open the protection report. So the marketing team would have to integrate that into their site.

Comment 4

[Johann Hofmann [:johannh]]

I think this more or less amounts to adding a new event type for opening the report here: https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/components/uitour/UITour.jsm#376

Comment 5

[chsiang]

Hi Justin,
Erica can provide you the API for Whats New Page.

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

The websites team has an incoming request to build a landing page for the protection report. In order to make the protection report landing page shareable by all web users, we should not send anyone directly into browser UI upon landing there. Instead, all users will get a protection report marketing page, with a UA-switched CTA:

• Fx <70 will be encouraged to update
• Fx70+ will be encouraged to view their protection report
• Non-Fx will be encouraged to download

We'll look in UITour docs for the appropriate API to accomplish the link. Thanks!

Comment 7

[Erica Wright [:ewright]]

Attachment: Bug 1577031 - make Protection Report page sharable via UITour.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b003634e1a7
make Protection Report page sharable via UITour. r=johannh

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4b003634e1a7

Comment 10

[Dorel Luca [:dluca]]

Backed out changeset 4b003634e1a7 (bug 1577031) for browser-chrome failures related to UITour. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265083374&repo=autoland&lineNumber=3055

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4b003634e1a7c78b4856be4419bdf6fa2e3c8797

Backout:
https://hg.mozilla.org/integration/autoland/rev/45c4f9b9d1d87a353261f1fb14739b7b9b7c76bd

Comment 11

[Johann Hofmann [:johannh]]

Why did this reach central?

Comment 12

[Dorel Luca [:dluca]]

I'm not sure, I think it wasn't very frequent in the beginning and just got merged.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/45c4f9b9d1d8

Comment 14

[Erica Wright [:ewright]]

I think I know why this happened, the RPM is trying to communicate with about:protections after it is gone - we've had similar things happen with this page in other tests. Waiting on a try build to finish.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6aaee8a6695
make Protection Report page sharable via UITour. r=johannh

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e6aaee8a6695

Comment 17

[Erica Wright [:ewright]]

Comment on attachment 9089506 [details]
Bug 1577031 - make Protection Report page sharable via UITour.

Beta/Release Uplift Approval Request

• User impact if declined: This makes the about:protections page linkable. We can now share a link for marketing purposes, we will be linking to it from the what's new page and from moz.org. We'd like to do that with the 70 release in conjunction with Skyline efforts.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): fairly simple patch, has a test, repeating a pattern already implemented for the about:newtab page.
• String changes made/needed: none

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9089506 [details]
Bug 1577031 - make Protection Report page sharable via UITour.

Makes about:protections linkable/sharable. Support for Skyline.
OK for beta uplift (beta 6)

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ab713decd5a

Comment 20

[Daniel Bodea [:danibodea]]

Can you help me with some way to verify the change? Thanks.

Comment 21

[Erica Wright [:ewright]]

(In reply to Bodea Daniel [:danibodea] from comment #20)

Can you help me with some way to verify the change? Thanks.

Sure, open a browser console and type in UITour.showProtectionReport(window). It should behave in the same way that UITour.showNewTab(window) does, except opening about:protections rather than about:newtab.

Comment 22

[Daniel Bodea [:danibodea]]

Using the "UITour.showProtectionReport(window)" command in Browser Console does the exact same thing as opening the "about:protections" page.

Nightly v70.0a1 from 2019-09-15 and Beta v70.0b6 builds show the Privacy Protections section (that contains the current Protection Level and a report of the blocked trackers in the last week), the "Look out for data breaches" section with the "Sign Up for Breach Alerts" button and the "Never forget a password again" section with the "View Logins" button and an encouragement to use the Lockwise app.

The Release v69.0 build also opens the same page that shows the Privacy Protections section (that contains the current Protection Level and a report of the blocked trackers in the last week), but does NOT show the "Look out for data breaches" section or the "Never forget a password again" section.

I will assume that this is the intended/expected behavior after the implementation and set the bug's status as VERIFIED. Please confirm that this is the expected result. Thank you.

Comment 23

[Erica Wright [:ewright]]

(In reply to Bodea Daniel [:danibodea] from comment #22)

Using the "UITour.showProtectionReport(window)" command in Browser Console does the exact same thing as opening the "about:protections" page.

Nightly v70.0a1 from 2019-09-15 and Beta v70.0b6 builds show the Privacy Protections section (that contains the current Protection Level and a report of the blocked trackers in the last week), the "Look out for data breaches" section with the "Sign Up for Breach Alerts" button and the "Never forget a password again" section with the "View Logins" button and an encouragement to use the Lockwise app.

The Release v69.0 build also opens the same page that shows the Privacy Protections section (that contains the current Protection Level and a report of the blocked trackers in the last week), but does NOT show the "Look out for data breaches" section or the "Never forget a password again" section.

I will assume that this is the intended/expected behavior after the implementation and set the bug's status as VERIFIED. Please confirm that this is the expected result. Thank you.

Thank you for testing this. The function UITour.showProtectionReport(window) is the part of this bug that needed to be tested. At the moment, this function is not being used anywhere, but it will be used by Moz.org and our whats new page soon. about:protections existing in 69 as well as 70 and 71 is also expected.