1577051 - FastBernoulliTrial.h has an implicit integer-to-float conversion that changes value, triggering a warning with new-enough clang

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Jeff Walden [:Waldo]]

clang tip has a compiler warning for implicit integer-to-float conversions that change value, and FastBernoulliTrial.h contains such a conversion (in code to truncate-and-clamp a double to size_t)

    double skipCount =
        std::floor(std::log(mGenerator.nextDouble()) * mInvLogNotProbability);
    if (skipCount < SIZE_MAX)
      mSkipCount = skipCount;
    else
      mSkipCount = SIZE_MAX;

in skipCount < SIZE_MAX when size_t on the right-hand side is converted to double.

Either value permissibly produced by that conversion is acceptable, so just do an explicit conversion to silence the warning.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1577051 - Fix an implicit-conversion-changes-value warning with new-enough clang by explicitly converting. r=froydnj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d72f6bb552f3
Fix an implicit-conversion-changes-value warning with new-enough clang by explicitly converting.  r=froydnj

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d72f6bb552f3