1577066 - Nursery.cpp contains an implicit integer-to-float conversion that changes value, triggering a warning with new-enough clang

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task)

Description

[Jeff Walden [:Waldo]]

The problem and fix here are a little fugly, but I don't know there's much clean to do about it.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1577066 - Fix an implicit-conversion-changes-value warning with new-enough clang in Nursery.cpp by doing a less-than comparison with the actually-representable next higher value. r=jonco

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcaf8571985f
Fix an implicit-conversion-changes-value warning with new-enough clang in Nursery.cpp by doing a less-than comparison with the actually-representable next higher value.  r=jonco

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset fcaf8571985f (Bug 1577066) for causing build bustages in Nursery.cpp CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=264143939&resultStatus=testfailed%2Cbusted%2Cexception&revision=fcaf8571985f825bcd23fbb3bd2f255097661a76

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264143939&repo=autoland&lineNumber=820
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264143922&repo=autoland&lineNumber=6186

Backout: https://hg.mozilla.org/integration/autoland/rev/6e46680a8c11fa13966689916cbe4c8bba87bff1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0948113e9229
Fix an implicit-conversion-changes-value warning with new-enough clang in Nursery.cpp by doing a less-than comparison with the actually-representable next higher value.  r=jonco

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0948113e9229

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0948113e9229