1577072 - Debian 10 - forms/input/text/line-height-1.5.html != forms/input/text/line-height-1.0.html | image comparison, max difference: 0, number of differing pixels: 0

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=263790090&repo=try
Full log: https://queue.taskcluster.net/v1/task/Fl_iy1UYRwOVaQ7DyBbFXw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Fl_iy1UYRwOVaQ7DyBbFXw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

Platform: debian10
Suite: reftest
Chunk: 1

Context:
[task 2019-08-28T00:29:11.464Z] 00:29:11 INFO - REFTEST TEST-START | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.5.html != file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.0.html
[task 2019-08-28T00:29:11.464Z] 00:29:11 INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.5.html | 9 / 11 (81%)
[task 2019-08-28T00:29:11.571Z] 00:29:11 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.5.html != file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.0.html | image comparison, max difference: 0, number of differing pixels: 0
[task 2019-08-28T00:29:11.571Z] 00:29:11 INFO - REFTEST IMAGE:

Comment 1

[Daniel Holbert [:dholbert]]

(Adding dependency on bug 349259 which is where this test comes from)

So the comparison here is that line-height-1.5.html != line-height-1.0.html

i.e. it's testing that these look different:
data:text/html,<input style="line-height:1.0">
data:text/html,<input style="line-height:1.5">

I don't think we have any strong justification to assert that... In fact, on my Ubuntu system, those ^^ data URIs look the same. For me, the text widget doesn't start to grow until the line-height reaches 1.7.

It looks like we already expect that line-heights below a certain threshold will all look the same for <input> widgets, since the previous reftest.list line is asserting that 0.5 and 1.0 render the same. I'm guessing the platform/theme influences the point at which an increasing line-height will start to look different.

Anyway: perhaps we can just bump this test to line-height:1.8 (and rename it accordingly), and call it good?

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1577072: Use a slightly larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r?dbaron

Comment 3

[Daniel Holbert [:dholbert]]

I don't know for sure that this change (s/1.5/1.8/) is sufficient; just guessing based on my local testing on Ubuntu 19.04 where I'm seeing a similar failure.

egao, if you could give this patch a Try run [or let me know how I can do that], I'd be much appreciative.

Comment 4

[Daniel Holbert [:dholbert]]

(as far as I can tell, this isn't a regression -- removing that keyword.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d029a9d6c0d
Use a slightly larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r=dbaron

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7d029a9d6c0d

Comment 7

[Intermittent Failures Robot]

1 failures in 5047 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1577072&startday=2019-08-26&endday=2019-09-01&tree=all

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7d029a9d6c0d

Comment 9

[Daniel Holbert [:dholbert]]

egao, could you double-check that this test isn't failing anymore, in a build from after the commit in comment 6?

(My patch here was just based on a guess & based on local testing in Ubuntu 19.04, so I'm not 100% sure if this was sufficient or if Debian 10 needs something stronger.)

Comment 10

[Edwin Takahashi (:egao | infrequent contributor)]

:dholbert - will do, I had the debian 10 enabling push landing again on mozilla-central after a backout, which would make it easier for me to check this - expected turnaround time is whenever the patch lands in mozilla-central without issues.

Keeping ni as a reminder.

Comment 11

[Edwin Takahashi (:egao | infrequent contributor)]

:dholbert - I have a push with newest mozilla-central here, running R1-R5:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=15e45dc96fa049a8d35cda1e1324f352a6d6c849

I checked R1 and found mentions of line-height-1.0.html but not line-height-1.5.html; not sure why that might be.

Comment 12

[Daniel Holbert [:dholbert]]

Sorry, I should've mentioned -- I renamed line-height-1.5.html to line-height-1.8.html as part of the patch here (so that it would continue to accurately describe its contents after my change).

I do see line-height-1.0.html and line-height-1.8.html being run & passing in an R2 log in that test run, so it looks like we're all set and the test (with its new name) is indeed now passing.

Thanks!

Comment 13

[Edwin Takahashi (:egao | infrequent contributor)]

Sorry, I had made a mistake in the push from comment 11 - that push was running on the old Ubuntu 16.04 image.

It looks like the test is failing on debian 10:

[task 2019-09-04T02:27:50.299Z] 02:27:50     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.8.html != file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.0.html | image comparison, max difference: 0, number of differing pixels: 0
[task 2019-09-04T02:27:50.299Z] 02:27:50     INFO - REFTEST   IMAGE: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAZjElEQVR4nO3cT4jndf3A8Z3FUzNtf1gWQWMDwwqW2EOIehFFKIROQocOQW1EEJm71w6ugumCip46GHYIOnVZ8KhkK+Egv7ls0h760TKyW7YZHVpyZtV9dQgGlXXXbcfnmN/HA96Hz3zm+/6+v4fX4cnM57trAAAAIrt2+gAAAMDiECAAAEBGgAAAABkBAgAAZAQIAACQESAAAEBGgAAAAJkrBsjFixfnzPqf5uT/rc7aSycsy7rGdXJtdc6s/2kuXrxYzDgAwEfKFQPkzPqf5v9PvTIXNjeK88DH3oXNjfnjqd/P2fXTO30UAIDcFQPk5Nqq+IBttrm5MSfXVnf6GAAAuSsGyNpLJ4pzwMIxWwDAIhIgsEPMFgCwiAQI7BCzBQAsIgECO8RsAQCLSIDADjFbAMAiEiCwQ8wWALCIBAjsELMFACwiAQI7xGwBAItIgMAOMVsAwCLatgD517/+NW+88cY1H+iD7nfbbbfNT37yk217v2s9D1wtAQIALKJtC5Dvfe97c//991/zgT7ofg8//PAcP358297vWs8DV0uAAACL6H82QGoftfPwv0+AAACLaFsC5MiRI7O0tDRLS0tz3XXXzUMPPTQzMxsbG3PkyJH53Oc+N/v27Zsf/OAHc/78+ZmZOXr06HzlK1+ZN998c2Zm/vnPf86NN944v/jFL953v3e6++6758knn9y6/upXvzo//elP55Zbbpnl5eU5ePDgvPjii++6/9RTT83tt98+n/zkJ+eWW26Zl19+eev+3r1754UXXti6Xl1dnZWVlct+PrgWAgQAWEQf6l9ADh06NN/85jfn3Llz8+qrr86dd945991338zMbG5uzpe//OV54oknZmbm8OHDc88991x2v3e6VIDccccds7a2Nn/961/nRz/60Vx//fWzubm5df/gwYPzu9/9bs6cOTM//vGP51Of+tT84x//mJnLB8gHOQ9cLQECACyiDy1A/v73v8/u3bvntdde2/rZb3/729m/f//W9YkTJ2bPnj3z7LPPzt69e+fs2bPvu997XSpAfv7zn29dnz9/fpaWluaVV1655P233357vvCFL8zPfvazmREg9AQIALCIPrQAeemll2ZpaWk+//nPb60bbrhhPv3pT7/rdd///vdn9+7d88tf/vKy+73XlQJkZmZ5eXlWV1ff9/63v/3tOXz48MwIEHoCBABYRB9agPzhD3+YXbt2zd/+9rfLvu7YsWOza9eu+fWvf33Z/d7rgwTIysrKZQPkO9/5ztZX+e7du3d+85vfbN0TIHzYBAgAsIi2NUB++MMfbl1vbGzM8vLyPPPMM+/7mlOnTs1nP/vZeeyxx+b666/feh7jUvu9138TII8//vi77h84cGB+9atfzczM/v373xVBlwqQy50HrpYAAQAW0bYFyIMPPjg333zz/OUvf9n6pqsHHnhg9u3bN88999xcuHBhXn755a0geOutt+bWW2+dRx99dGZmvvGNb8yhQ4cuu987/TcBsmfPnjl+/PicO3dujh49Ovv37996SP1b3/rW3HrrrbO+vj7r6+tz6NChdwXIlc4DV0uAAACLaNsC5PXXX5+77rprVlZW5rvf/e7M/OdB72PHjs2XvvSl+cQnPjE33XTTPP300zPzn3+9OnDgwFy4cGFmZtbX12dlZWWef/75993vnf6bALn33nvni1/84uzZs2e+9rWvzenTp7d+989//vN8/etfn+Xl5bn55pvnkUcemc985jOX/XxwLQQIALCIti1APuouFSiwkz4uswUAcDUECOyQj8tsAQBcDQECO+TjMlsAAFdDgMAO+bjMFgDA1ViYAIGPGrMFACwiAQI7xGwBAItIgMAOMVsAwCISILBDzBYAsIiuGCAn11bnwuZGcRZYGJubG3NybXWnjwEAkLtigJxdPz1/PPX72RQhsC02Nzfmj6d+P2dfPb3TRwEAyF0xQC5evDhn10/PybXVWXvphGVZ17hOrq3O2VdPz8WLF4sZBwD4SLligAAAAGwXAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGQECAAAkBEgAABARoAAAAAZAQIAAGT+DdvcvwrZZyK7AAAAAElFTkSuQmCC
[task 2019-09-04T02:27:50.300Z] 02:27:50     INFO - REFTEST INFO | Saved log: START file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.8.html
[task 2019-09-04T02:27:50.300Z] 02:27:50     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-09-04T02:27:50.301Z] 02:27:50     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-09-04T02:27:50.301Z] 02:27:50     INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-09-04T02:27:50.301Z] 02:27:50     INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-09-04T02:27:50.302Z] 02:27:50     INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-09-04T02:27:50.302Z] 02:27:50     INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-09-04T02:27:50.303Z] 02:27:50     INFO - REFTEST TEST-END | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.8.html != file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/forms/input/text/line-height-1.0.html

The push is https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=94fa4a85d50c81e7fd898ead492c6f5de6b83524&selectedJob=264872150&searchStr=linux%2Cx64%2Copt%2Creftests%2Ctest-linux64%2Fopt-reftest-e10s-2%2Cr%28r2%29 (ignore the green symbols; for some reason the failed state is not being properly reported).

Comment 14

[Daniel Holbert [:dholbert]]

Gotcha, OK.

I set up a Debian 10 VM locally (with Gnome as the desktop environment, when prompted during installation), and I can confirm that line heights up through around 2.2 all produce the same height.

This is a bit unusually large, but I think it's not crazy -- if I'm understanding correctly, the expectation is that line-height is only supposed to make the field taller once it surpasses the default height of the field. And the field is just unusually tall by default in the Debian 10 Gnome theme ("Adwaita").

Let's just change the test to have line-height:2.5 (up from the original 1.5 and my modified 1.8) so that it's large enough to make a difference on all known/tested environments, with a little bit of extra wiggle room.

Comment 15

[Daniel Holbert [:dholbert]]

Attachment: Bug 1577072 followup: Use an even larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r?dbaron

Previous commit on this bug bumped up the test from a line-height of 1.5
to 1.8, but that's still not taller than the default widget height on Debian.
But 2.5 does seem to be sufficiently tall to produce a size difference.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2345d813f59d
followup: Use an even larger line-height in our "bigger-than-one" text-input line-height reftest, to accommodate bigger widgets on Debian. r=dbaron

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2345d813f59d