Closed Bug 1577073 Opened 1 year ago Closed 11 months ago

accessible/tests/mochitest/role/test_aria.html contains XHTML even though the file is HTML

Categories

(Core :: Disability Access APIs, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: Jamie, Assigned: southort, Mentored)

Details

(Whiteboard: [lang=html])

Attachments

(1 file)

Discovered while reviewing https://phabricator.services.mozilla.com/D43293 (bug 1357071).

accessible/tests/mochitest/role/test_aria.html contains lots of self-closing XHTML tags (/>). For example:

<span id="aria_alert" role="alert"/>

However, this is definitely an HTMl file, not an XHTML file:

<!DOCTYPE html>

The practical upshot is that these tags that are supposed to close never do. We end up with an alert containing an alertdialog containing an application... and so on. Because these are just role tests, this normally isn't noticeable. However, it does have an impact for roles like region which change depending on whether there is a name, which is why the ARIA implicit value work (bug 1357071) broke this. (See https://phabricator.services.mozilla.com/D43293#1319331 for specific details.)

For the specific case breaking bug 1357071, we'll land a fix for that there. However, we should still fix the rest of these.

Mentor: jteh
Whiteboard: [lang=html]

I would like to help with this fix, but I am not experienced with contributions so I would need some guidance there.

Flags: needinfo?(jteh)

Sure! Thanks for your willingness to help!

With regard to how to contribute, these documents are a good place to start:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
There's a bunch of other related documentation here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide

With regard to this specific change, it's a change which only touches the test case. You'll need to make the changes as described in comment 0, then run the test and confirm that it works:
./mach mochitest accessible/tests/mochitest/role/test_aria.html
If it's all good, you're ready to submit the patch as per the documentation above.

Thanks!

Flags: needinfo?(jteh)

I want to contribute to this.

Thank you for your willingness to help! You can find instructions in comment #2.

Assignee: nobody → southort
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48548c06b8e0
accessible/tests/mochitest/role/test_aria.html contains XHTML even though the file is HTML. r=Jamie
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.