Enable WS to be on by default in Nightly and Beta
Categories
(DevTools :: Netmonitor, task, P2)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: Harald, Assigned: tanhengyeow)
References
Details
(Keywords: dev-doc-needed)
Attachments
(2 files)
1.07 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Let it ride the train to pre-release so we can further stabilize the feature.
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Enable WS to be on by default in Nightly and Beta
Updated•5 years ago
|
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dac2c9556da5 Enable WS to be on by default in Nightly and Beta. r=Honza
Comment 4•5 years ago
|
||
bugherder |
Comment 5•5 years ago
|
||
Note that EARLY_BETA_OR_EARLIER
is commonly used to enable something in (early) beta and nightly (and dev-edition). I believe that defined(NIGHTLY_BUILD) || defined(MOZ_DEV_EDITION)
leaves beta out entirely.
Comment 6•5 years ago
|
||
bugherder uplift |
Comment 7•5 years ago
|
||
(In reply to Panos Astithas (he/him) [:past] (please ni?) from comment #5)
Note that
EARLY_BETA_OR_EARLIER
is commonly used to enable something in (early) beta and nightly (and dev-edition). I believe thatdefined(NIGHTLY_BUILD) || defined(MOZ_DEV_EDITION)
leaves beta out entirely.
Thanks for the note Panos!
I was just talking to Harald, it's actually a good oversight since we can differentiate DevEdition and drag people to it a bit more.
Honza
Updated•5 years ago
|
Comment 8•5 years ago
•
|
||
Maybe I missed something but I can't tell what WS is. Can you give me a description?
[EDIT: I figured out that this refers to web sockets but I could still use a bit more information in order to document it.]
Comment 9•5 years ago
|
||
Irene, you can read a blog post about WebSocket Inspector (published today)
https://hacks.mozilla.org/2019/10/firefoxs-new-websocket-inspector/
Honza
Description
•