1577232 - DIsk image (dmg) background image has misaligned text background

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Dan Callahan [:callahad]]

Attachment: Screen Shot 2019-08-28 at 18.17.09.png

See attached screenshot.

Firefox Developer Edition 70.0b1, downloaded 2019-08-28, has a misaligned text background.

Screenshot taken on macOS 10.14.5 ("Mojave").

Comment 1

[Dão Gottwald [:dao]]

I guess bug 1570397 caused this? Is this background part of the branded image?

Comment 2

[Stephen Horlander [:shorlander]]

(In reply to Dão Gottwald [::dao] from comment #1)

I guess bug 1570397 caused this? Is this background part of the branded image?

Yes, it is part of the image.

If you happen to have "Show all filename extensions" checked the name is long enough to wrap. I'll try and adjust it so it fits both cases.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Stephen are you still working on this? We could still take a patch in 70 beta.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Update the Developer Edition background image to fit the application name

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa67fa4f7a2d
Update the Developer Edition background image to fit the application name r=dao

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 9098530 [details]
Update the Developer Edition background image to fit the application name

Beta/Release Uplift Approval Request

• User impact if declined: See attachment 9088752 [details]
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See attachment 9088752 [details]
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Image swap
• String changes made/needed: none

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/aa67fa4f7a2d

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Actually, since we only have one more beta/dev ed release left for 70, let's let this fix ride with 71.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9098530 [details]
Update the Developer Edition background image to fit the application name

Thank you for the fix!
It should show up for 71 dev ed starting next week (the first 71.0b1 comes out next Tuesday.)

Comment 11

[Daniel Bodea [:danibodea]]

Adding myself to the CC list. Waiting for Dev Edition 71.0b1 to verify. Thanks.

Comment 12

[Daniel Bodea [:danibodea]]

I have verified this fix in Devedition v71.0b2 on Mac OS 10.14.4.