1577241 - moz-phab is triggering the clang format hook for every patch several times

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

% moz-phab submit 490360 tip                                                       [18:42:50]
Submitting 10 commits for review:
(New) 490369:31971ab84426 Bug 1577236 - clang-10: Disable -Wimplicit-int-float-conversion for chromium r?glandium
[...]
(New) 490360:1cf30190c7b3 Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in gfx/ r?nical
Warning: found 25 untracked files (will not be submitted):
Submit to Phabricator (YES/No/Always)? 

Creating new revision:
490360:1cf30190c7b3 Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in gfx/ r?nical
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 SKIP STAGING  Phabricator does not support staging areas for this repository.
Created a new Differential revision:
        Revision URI: https://phabricator.services.mozilla.com/D43776

Included changes:
  M       gfx/layers/basic/BasicCompositor.cpp
  M       gfx/layers/basic/BasicLayerManager.cpp
  M       gfx/layers/opengl/CompositorOGL.cpp
  M       gfx/layers/wr/WebRenderCommandBuilder.cpp
  M       gfx/src/nsCoord.h
  M       gfx/webrender_bindings/Moz2DImageRenderer.cpp
created new head
rebasing 490360:1cf30190c7b3 "Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in gfx/ r?nical"
Processing 6 file(s)...
rebasing 490375:b6b68acc0f5e "Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in gfx/ r?nical" (tip)
Processing 6 file(s)...
[...]
Processing 2 file(s)...
rebasing 490369:31971ab84426 "Bug 1577236 - clang-10: Disable -Wimplicit-int-float-conversion for chromium r?glandium"

Creating new revision:
490377:11293455fb0e Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in dom/media r?jya
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 SKIP STAGING  Phabricator does not support staging areas for this repository.
Created a new Differential revision:
        Revision URI: https://phabricator.services.mozilla.com/D43778

Included changes:
  M       dom/media/VideoUtils.cpp
  M       dom/media/platforms/agnostic/bytestreams/H264.cpp
  M       dom/media/webaudio/DelayBuffer.h
created new head
rebasing 490377:11293455fb0e "Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in dom/media r?jya"
Processing 3 file(s)...
rebasing 490391:4b8c547abd81 "Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in dom/media r?jya" (tip)
Processing 3 file(s)...
[...]
Processing 2 file(s)...
rebasing 490385:899e6cf1fbc1 "Bug 1577236 - clang-10: Disable -Wimplicit-int-float-conversion for chromium r?glandium"

Grep for "Processing X file(s)..."
We probably don't want to run the hgext in that case.
Here is the hgext:
https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/clang-format/__init__.py

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Connor, any idea how to do that?

Comment 2

[:glob ✱]

moz-phab sets the MOZPHAB environmental variable; that could be used by the hook to disable execution on commits performed by moz-phab.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Fix typos to test Bug 1577241

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Fix typos to test Bug 1577241

Comment 5

[Sylvestre Ledru [:Sylvestre]]

https://phabricator.services.mozilla.com/D43962

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Attachment: hgext: clang-format hg hook: (Bug 1577241) Skip clang-format task when called by moz-phab r?glob

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/099edd42753e
hgext: clang-format hg hook: Skip clang-format task when called by moz-phab r=glob