Closed Bug 1577314 Opened 3 months ago Closed 3 months ago

@TimeoutMillis is not respected in tests

Categories

(GeckoView :: General, task, P3)

Unspecified
All

Tracking

(firefox69 wontfix, firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: Agi, Assigned: Agi)

Details

Attachments

(1 file)

This is evident from e.g. evaluateJS_canTimeout which should take 1s but actually takes 30s:

    @TimeoutMillis(1000)
    @Test(expected = UiThreadUtils.TimeoutException::class)
    fun evaluateJS_canTimeout() {
 0:50.84 TEST_START: org.mozilla.geckoview.test.GeckoSessionTestRuleTest.evaluateJS_canTimeout
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: numtests=498
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: stream=.
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: test=evaluateJS_canTimeout
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.GeckoSessionTestRuleTest
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: current=81
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS_CODE: 0
 1:21.68 TEST_END: PASS

Notice the gap from 0:50 to 1:21.

Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b52fcec46987
Enforce @TimeoutMillis in tests. r=snorp
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

firefox69=wontfix because we don't need to uplift this test fix to GV 69 Beta.

You need to log in before you can comment on or make changes to this bug.