1577314 - @TimeoutMillis is not respected in tests

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

This is evident from e.g. evaluateJS_canTimeout which should take 1s but actually takes 30s:

    @TimeoutMillis(1000)
    @Test(expected = UiThreadUtils.TimeoutException::class)
    fun evaluateJS_canTimeout() {

 0:50.84 TEST_START: org.mozilla.geckoview.test.GeckoSessionTestRuleTest.evaluateJS_canTimeout
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: numtests=498
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: stream=.
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: test=evaluateJS_canTimeout
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.GeckoSessionTestRuleTest
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: current=81
 1:21.68 org.mozilla.geckoview.test INSTRUMENTATION_STATUS_CODE: 0
 1:21.68 TEST_END: PASS

Notice the gap from 0:50 to 1:21.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1577314 - Enforce @TimeoutMillis in tests.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b52fcec46987
Enforce @TimeoutMillis in tests. r=snorp

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b52fcec46987

Comment 4

[Chris Peterson [:cpeterson]]

firefox69=wontfix because we don't need to uplift this test fix to GV 69 Beta.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b52fcec46987