1577316 - Extension Notifications show origin and settings cog

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P1)

Description

[M8R-p7]

Attachment: Notification with settings cog menu

Notifications produced by extensions (browser.notifications.create()) now show a 'via' origin and setting cog. These refer to the extension only by their Internal UUID.

STR:

1. Install an extension that provides notifications (e.g. webextensions-examples/notify-link-clicks )
2. Trigger a notification

Actual Results:
The notification comes with a confusing 'via' origin message and semi-functional settings cog button. Choosing to disable notifications from the extension origin has no apparent effect - the origin is not added to the Notifications Exceptions List, no errors appear in the Browser Console, and future notifications continue to appear as normal.

Expected Results:
Assuming this is not an intentional change, notifications from extensions should not show the 'via' origin and settings cog.

Comment 1

[Rob Wu [:robwu]]

This is likely caused by bug 1559697 , which addressed an issue on macOS.
I can confirm that it's not possible to disable notifications via the triple-dot menu on the notification on macOS either.

The change is currently on Nightly and Beta, but hasn't reached Release yet.

I'll investigate and request uplift if possible.

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1577316 - Omit principal from extension notification

This was added in bug 1577316 , to show the Close button on macOS.
It had unwanted side effects, including the appearance of buttons
that don't have any apparent effect. To resolve this regression,
the change is undone.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4711c3019b28
Omit principal from extension notification r=rpl

Comment 4

[Rob Wu [:robwu]]

Comment on attachment 9102541 [details]
Bug 1577316 - Omit principal from extension notification

Beta/Release Uplift Approval Request

• User impact if declined: Desktop notifications from extensions contain confusing text (an extension GUID) and non-functional notification settings button. This is a UI regression from a patch that landed in 70, and it would be nice to include this in RC or to ride along with a future dot release.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a simple change that basically reverts https://hg.mozilla.org/mozilla-central/rev/359eff208383 . The effect is well-understood (revert to the behavior of extension notifications in Firefox 69 and earlier) and only affects extension code.
• String changes made/needed: none

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4711c3019b28

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Verifying this in nightly/beta would make me feel better about taking this on release.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Does this also affect Fennec?

Comment 8

[Rob Wu [:robwu]]

The regression was introduced in Firefox 70, and Fennec is on ESR68, so this doesn't affect Fennec.

As an easy STR for manual reproduction, I did the following:

1. Optional: Set alerts.useSystemBackend to false
2. Install https://addons.mozilla.org/en-US/firefox/addon/display-_anchors/
3. While on the same page (addons.mozilla.org), click on the extension button. That will trigger a desktop notification.

Without the patch, in Firefox 70/71, the notification included the GUID ad a cog (as seen in the screenshot in the original report).
When step 1 is skipped, native desktop notifications are used. On macOS (and I believe Windows as well), the native notification includes a cog and GUID. On my Linux system, there is nothing that resembles a cog or GUID.

With the patch (and in Firefox 69 and earlier), the GUID and cog are not displayed (regardless of step 1).

Comment 9

[Miruna Curtean]

Verified fixed on Windows 10 Pro 64-bit and Ubtunu 18.04.3 LTS under Firefox Nightly 71.0a1 (Build ID:20191020214712) and on macOS Catalina 10.15 with Firefox Nightly71.0a1 (Build ID:20191021095628) using the recommended STR.
The GUID and the cog are no longer displayed on the “Display #Anchors failed” notification. This was also testing in private mode.
The fix is not yet in Beta so I will test that as well, after the uplift.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9102541 [details]
Bug 1577316 - Omit principal from extension notification

Fix for confusing UI regression, verified in nightly.
Let's uplift as a ridealong for 70.1

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/88233e93e41c

Comment 12

[Miruna Curtean]

Verified fixed in Firefox 70.0.1 (20191029161003) on Windows Pro 10 640-bit and Ubtunu 18.04.3 LTS. The notification did not include the GUID ad a cog anymore.