1577324 - Certificate error code on cert error pages is not styled as a link anymore

Status: VERIFIED FIXED

(Firefox :: Security, defect, P1)

Description

[Johann Hofmann [:johannh]]

See screenshot. That should look like a link, to signify that you can click on it.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Screenshot 2019-08-28 at 22.57.27.png

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1577324 - Backed out changeset 0a7463d82e5f. r=timhuang

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1577324 - Backed out changeset 93ae831e2fb9. r=timhuang

Depends on D43948

Comment 4

[Phabricator Automation]

Comment on attachment 9089023 [details]
Bug 1577324 - Backed out changeset 0a7463d82e5f. r=timhuang

Revision D43948 was moved to bug 1576072. Setting attachment 9089023 [details] to obsolete.

Comment 5

[Phabricator Automation]

Comment on attachment 9089024 [details]
Bug 1577324 - Backed out changeset 93ae831e2fb9. r=timhuang

Revision D43949 was moved to bug 1576072. Setting attachment 9089024 [details] to obsolete.

Comment 6

[Johann Hofmann [:johannh]]

Attachment: Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11

The way that we're setting this now actually makes it impossible for this not to be a link, AFAICS.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71f0bf2aee9b
Always style the error code field in error pages as a link. r=nhnt11

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/71f0bf2aee9b

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/71f0bf2aee9b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This seems like it'd be a pretty safe ride-along for an Fx69 dot release? Do you agree, Johann?

Comment 11

[Johann Hofmann [:johannh]]

Comment on attachment 9089214 [details]
Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11

Beta/Release Uplift Approval Request

• User impact if declined: On cert error pages, error codes don't get a hover state so it's not clear that you can click them to get more information
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS fixup, limited to cert error pages
• String changes made/needed: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9089214 [details]
Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11

CSS-only fix to un-break link styling on the cert error page. Approved for 69.0.1.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/4b984be98c54

Comment 14

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 70.0a1 (BuildId:20190828214452)

This issue is verified fixed using Firefox 70.0b7 (BuildId:20190916074538) and Firefox 69.0.1 (BuildId:20190917135527) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.