Closed Bug 1577324 Opened 3 months ago Closed 3 months ago

Certificate error code on cert error pages is not styled as a link anymore

Categories

(Firefox :: Security, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- verified
firefox70 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 2 obsolete files)

See screenshot. That should look like a link, to signify that you can click on it.

Depends on D43948

Comment on attachment 9089023 [details]
Bug 1577324 - Backed out changeset 0a7463d82e5f. r=timhuang

Revision D43948 was moved to bug 1576072. Setting attachment 9089023 [details] to obsolete.

Attachment #9089023 - Attachment is obsolete: true

Comment on attachment 9089024 [details]
Bug 1577324 - Backed out changeset 93ae831e2fb9. r=timhuang

Revision D43949 was moved to bug 1576072. Setting attachment 9089024 [details] to obsolete.

Attachment #9089024 - Attachment is obsolete: true

The way that we're setting this now actually makes it impossible for this not to be a link, AFAICS.

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71f0bf2aee9b
Always style the error code field in error pages as a link. r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

This seems like it'd be a pretty safe ride-along for an Fx69 dot release? Do you agree, Johann?

Flags: needinfo?(jhofmann)

Comment on attachment 9089214 [details]
Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11

Beta/Release Uplift Approval Request

  • User impact if declined: On cert error pages, error codes don't get a hover state so it's not clear that you can click them to get more information
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small CSS fixup, limited to cert error pages
  • String changes made/needed: None
Flags: needinfo?(jhofmann)
Attachment #9089214 - Flags: approval-mozilla-release?

Comment on attachment 9089214 [details]
Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11

CSS-only fix to un-break link styling on the cert error page. Approved for 69.0.1.

Attachment #9089214 - Flags: approval-mozilla-release? → approval-mozilla-release+

I have managed to reproduce this issue using Firefox 70.0a1 (BuildId:20190828214452)

This issue is verified fixed using Firefox 70.0b7 (BuildId:20190916074538) and Firefox 69.0.1 (BuildId:20190917135527) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.