1577359 - Build atob and btoa for Thunderbird

Status: RESOLVED FIXED

(NSS :: Test, enhancement)

Description

[Kai Engert [:KaiE:]]

Build atob and btoa when building NSS for Thunderbird.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: 1577359.patch

Do simply patches still work, or are we required to go through phabricator?

Comment 2

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9088901 [details] [diff] [review]
1577359.patch

Review of attachment 9088901 [details] [diff] [review]:
-----------------------------------------------------------------

They still work fine for NSS and NSPR. It's becoming impossible to land except via Phabricator/Lando in mozilla-central though.

Comment 3

[Kai Engert [:KaiE:]]

Thanks J.C.! Setting checkin reminder for myself, for after the current freeze.

Comment 4

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/1fe61aadaf5795a3bb09f2a444484108f158dc78

Comment 5

[Jorg K (CEST = GMT+2)]

This merged in bug 1577822 and now Mac builds are busted :-(

make[4]: *** [../../../../../dist/bin/btoa] Error 1
make[3]: *** [security/nss/cmd/btoa/btoa_btoa/target] Error 2

Comment 6

[Jorg K (CEST = GMT+2)]

Correction: Mac and Windows builds, so it took out two of our three platforms and technically I'd have to close the tree now.

Comment 7

[J.C. Jones [:jcj] (he/they)]

Mac builds of Thunderbird?

Comment 8

[J.C. Jones [:jcj] (he/they)]

Can you point us to a log?

Comment 9

[Jorg K (CEST = GMT+2)]

Yes, Mac and Windows builds:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=51f6d35de7f4fca23ad24c9c300318935d846897

Comment 10

[Kai Engert [:KaiE:]]

[task 2019-09-19T07:42:40.963Z] 07:42:40 INFO - Undefined symbols for architecture x86_64:
[task 2019-09-19T07:42:40.963Z] 07:42:40 INFO - "_NSSBase64Encoder_Create_Util", referenced from:
[task 2019-09-19T07:42:40.963Z] 07:42:40 INFO - _main in btoa.o
[task 2019-09-19T07:42:40.963Z] 07:42:40 INFO - "_NSSBase64Encoder_Update_Util", referenced from:
[task 2019-09-19T07:42:40.963Z] 07:42:40 INFO - _main in btoa.o
[task 2019-09-19T07:42:40.963Z] 07:42:40 INFO - "_NSSBase64Encoder_Destroy_Util", referenced from:
[task 2019-09-19T07:42:40.963Z] 07:42:40 INFO - _main in btoa.o

Sorry, I didn't except this to happen. I should have made a try build of Thunderbird on all platforms.

I think it will be sufficient to add entries to comm/mailnews/nss-extra.symbols

Comment 11

[Kai Engert [:KaiE:]]

Attachment: 1577359-winmac.patch

This is a patch for comm-central, I haven't yet tested it, and I don't have a curent local build, so I cannot test it quickly. Should we attempt to check it in, or do you want to wait for me to have a verified fix?

Comment 12

[Jorg K (CEST = GMT+2)]

Attachment: 1577359-winmac.patch - with decoder symbols

Surprisingly the original patch with the encoder symbols doesn't work, but this one does.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4028b82f6b6
Follow-up: Add NSSBase64Decoder_* symbols to nss-extra.symbols. r=jorgk

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 9093840 [details] [diff] [review]
1577359-winmac.patch

Sigh, still doesn't work on Mac with the decoder symbols although I carefully checked that Windows and Mac had the same error messages. I'll land this, too.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/17dd60cb1d5c
Follow-up: Add NSSBase64Encoder_* symbols to nss-extra.symbols. r=jorgk

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/220b3257a60a
Follow-up: remove NSSBase64Decoder_* symbols again. r=me DONTBUILD

Comment 17

[Jorg K (CEST = GMT+2)]

Well, the push with the decoder symbols added didn't work, but it did work locally, unless I messed up.
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=d4028b82f6b6fd19d41fe0cc45ab6482f5c53d52
I've taken them out again.

Comment 18

[Jorg K (CEST = GMT+2)]

I tried to retrace the steps that led to the faulty results. All I can say is that changing mailnews/nss-extra.symbols doesn't trigger a re-make of the dependent targets. Right now I've remove all NSSBase64XXcoder_* symbols again locally and it still compiles. Since Kai's original patch works for Mac in automation (Windows not done yet), we're done here. Sorry about the noise.

Comment 19

[Jorg K (CEST = GMT+2)]

Comment on attachment 9093847 [details] [diff] [review]
1577359-winmac.patch - with decoder symbols

That appeared to fix the problem locally, but as I wrote, not so easy to tell, see previous comment.

Comment 20

[Kai Engert [:KaiE:]]

Jörg, one tool does encoding, the other does decoding. The build might have stopped building after the first failure. It's possible that all those symbols are required. With some symbols backed out, one of the tools might again fail to build.

I'll submit a try build for win and mac with the current state of comm-central. Let's see if it fails. If it does, we might have to reland those symbols.

Comment 21

[Jorg K (CEST = GMT+2)]

Yes, thanks. The successful Daily was built with both sets (decode/encode). Let's see what happens after the decode backout.

Comment 22

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2a1507d53ad55de2410691d27f93d5e191d0ea8d

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/344aca0c9c42
Follow-up: Add NSSBase64Decoder_* symbols to nss-extra.symbols (again). r=jorgk DONTBUILD

Comment 24

[Jorg K (CEST = GMT+2)]

That try failed, so the decode symbols are needed after all. Finally done here.