Closed
Bug 1577371
Opened 5 years ago
Closed 5 years ago
bad timezone check in toolkit/components/telemetry/tests/unit/test_TelemetrySession.js (offsets up to UTC+14 are a thing)
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: benc, Assigned: benc)
Details
Attachments
(2 files)
|
1.58 KB,
patch
|
Details | Diff | Splinter Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
Steps to replicate:
- move to New Zealand (or even better: Kiribati)
- run:
./mach xpcshell-test toolkit/components/telemetry/tests/unit/test_TelemetrySession.js
Expected results:
Test should pass without complaint.
Observed results:
Timezone check fails for the test Jan 1st 2020 test date, which is NZDT (NZ daylight time, UTC+13).
|
Assignee | |
Comment 1•5 years ago
|
||
The existing check limits timezones to range -12 to +12 UTC. However offsets up to UTC+14 are a thing.
eg: https://en.wikipedia.org/wiki/UTC%2B14:00
Assignee: nobody → benc
|
||
Comment 3•5 years ago
|
||
Ben, maybe you want to submit that through phab and get it reviewed/landed.
Status: NEW → ASSIGNED
Summary: bad timezone check in toolkit/components/telemetry/tests/unit/test_TelemetrySession.js → bad timezone check in toolkit/components/telemetry/tests/unit/test_TelemetrySession.js (offsets up to UTC+14 are a thing)
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55197c40074d
Fix timezone range check in TelemetrySession unit test. r=chutten
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Comment 7•5 years ago
|
||
| bugherder landing | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•