Properly cleanup Browser Console when closing its window
Categories
(DevTools :: Console, defect, P1)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(1 file)
We create a new DebuggerClient
each time we open the Browser Console (devtools/client/webconsole/browser-console-manager.js#109 ), but it is never closed.
Assignee | ||
Comment 1•5 years ago
|
||
This blocks Bug 1572484, as we currently don't destroy the content target actors, which causes a memory leak in the test.
Assignee | ||
Comment 2•5 years ago
|
||
We store the created DebuggerClient when opening the Browser Console
so we can close it when closing the Browser Console window.
The Browser Console window unload
event listener is moved out of
the BrowserConsole class to the BrowserConsoleManager, so we can close
the DebuggerClient when the window is closed (plus it makes more sense
to have it here since that's where we create the window).
Finally, functions that were inlined in toggleBrowserConsole are moved
as method of the BrowserConsoleManager for clarity.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ba13ab83751 Cleanup Browser Console when closing its window. r=ochameau.
Comment 4•5 years ago
|
||
bugherder |
Comment 5•5 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Updated•3 years ago
|
Description
•