1577458 - Term for Lockwise brand unreplaced in the whatsnew panel

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Francesco Lodolo [:flod]]

Attachment: immagine.png

One possible explanation is that the source is not loading brandings.ftl, where this term is defined.

Comment 1

[Francesco Lodolo [:flod]]

I see an inclusion, but I'm not sure if this is the relevant code for this feature
https://searchfox.org/mozilla-central/rev/8ea946dcf51f0d6400362cc1d49c8d4808eeacf1/browser/components/newtab/content-src/asrouter/templates/FirstRun/FirstRun.jsx#15

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Bug 1577458 - Add fluent branding files to Whats New Panel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f021f1c28e0
Add fluent branding files to Whats New Panel r=Mardak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9f021f1c28e0

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9f021f1c28e0

Comment 6

[Negritas Sergiu]

I didn't manage to reproduce the issue on Win10 x64 or Ubuntu 18 LTS x64. Could you please verify that the issue is fixed using the latest beta https://archive.mozilla.org/pub/firefox/candidates/70.0b11-candidates/build1/? Thank you!

Comment 7

[Francesco Lodolo [:flod]]

I'm not seeing that message on Beta, only on Nightly (where it's fixed).

Comment 8

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-10-04 at 11.39.02.png

You only get the alternative message that contains the Lockwise term if you are logged in to FxA. Screenshot is taken in Beta.