1577499 - Implement transient activation flag

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

See https://github.com/whatwg/html/pull/3851.

The transient activation flag indicates the current activation state: Every time document is activated, the UA sets the flag to true. And the UA sets the flag to false when the flag expires.

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1577499 - Part 1: Implement transient activation flag;

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1577499 - Part 2: Add tests for transient user activation;

Comment 3

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7f49a627ae75b50e6e8667ff1873467e986b70e

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1577499 - Part 3: Add cross-origin test for has-been-user-activated flag;

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=590ad8067003269ad5d959060db4c355ec612602

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/991685fb60f5
Part 1: Implement transient activation flag; r=smaug
https://hg.mozilla.org/integration/autoland/rev/cb2ebcd8d0f5
Part 2: Add tests for transient user activation; r=smaug
https://hg.mozilla.org/integration/autoland/rev/2469f247e873
Part 3: Add cross-origin test for has-been-user-activated flag; r=smaug

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/991685fb60f5
https://hg.mozilla.org/mozilla-central/rev/cb2ebcd8d0f5
https://hg.mozilla.org/mozilla-central/rev/2469f247e873

Comment 8

[Chris Mills [:cmills]]

I don't really understand this, or what documentation is needed for it. Can you give me some help in explaining what this is for, what MDN docs need updating, and what content needs to be added? Thanks!

Comment 9

[Karl Tomlinson (:karlt)]

Edgar, we are considering the possibility of changing getDisplayMedia()'s transient activation test to look at the toplevel Window, for bug 1704278. (Feature policy default allowlist is "self", so a parent has already opted in and requiring a click in the iframe seems overkill.)

Are you aware of any reason why we should not extend WindowContext::mUserGestureStart to out-of-process WindowContext's?

Comment 10

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

The main reason for that is there wasn't such a use case, and referencing the user gesture status from another window isn't usually what we want, I think that is why spec defines a rule to propagate the activation state, https://html.spec.whatwg.org/multipage/interaction.html#activation-notification. The restriction of in-process-only could help to catch possible misusage.

Comment 11

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Chris Mills [:cmills] from comment #8)

I don't really understand this, or what documentation is needed for it. Can you give me some help in explaining what this is for, what MDN docs need updating, and what content needs to be added? Thanks!

I think the documentation for UserActivation interface which is tracked in bug 1791079 could cover this one, so remove the dev-doc-needed here.